Closed
Bug 839596
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Add optimized string concatenation stub.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: djvj, Assigned: djvj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
ss date-format-xparb is hitting this a lot.
|
Assignee | |
Updated•12 years ago
|
Assignee: general → kvijayan
|
|
Assignee | |
Comment 1•12 years ago
|
||
This brings us down to about 1.3x slower than JM+Ion on SS.
Attachment #711966 -
Flags: review?(jdemooij)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 711966 [details] [diff] [review]
Patch.
Review of attachment 711966 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/BaselineIC.h
@@ +308,5 @@
> \
> _(BinaryArith_Fallback) \
> _(BinaryArith_Int32) \
> _(BinaryArith_Double) \
> + _(BinaryArith_Strcat) \
We should try to avoid ugly names like that. StringConcat or Concat, like Ion.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 711966 [details] [diff] [review]
Patch.
Review of attachment 711966 [details] [diff] [review]:
-----------------------------------------------------------------
Cool. I agree with the StringConcat/Concat suggestion in comment 2 though.
Attachment #711966 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #2)
> Comment on attachment 711966 [details] [diff] [review]
> Patch.
>
> Review of attachment 711966 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: js/src/ion/BaselineIC.h
> @@ +308,5 @@
> > \
> > _(BinaryArith_Fallback) \
> > _(BinaryArith_Int32) \
> > _(BinaryArith_Double) \
> > + _(BinaryArith_Strcat) \
>
> We should try to avoid ugly names like that. StringConcat or Concat, like
> Ion.
Advice taken :) Although I wouldn't call "strcat" ugly.. it's just beautiful in it's own way ;)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•