Closed
Bug 839625
Opened 12 years ago
Closed 12 years ago
Incoming rotate events while image is snapping are mishandled
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: waterlo1, Assigned: waterlo1)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130205 Firefox/21.0
Build ID: 20130205153002
Steps to reproduce:
When rotating an image, there is a 0.3s snap to the nearest 90. If, during this 0.3s time period, a new rotation gesture is performed, behavior gets weird
Actual results:
e.g., the image may rotate 270 degrees in the wrong direction instead of 90 degrees in the right direction.
Other odd behavior may occur
Expected results:
Either:
1) New rotation gestures should be ignored while snapping, or
2) Snapping should cease, and behavior should return to being locked to the gesture.
--As the implementer of rotation, the first of these two options would be much easier to do.
Assignee | ||
Updated•12 years ago
|
Severity: normal → minor
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → waterlo1
Assignee | ||
Updated•12 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•12 years ago
|
Component: Untriaged → General
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•12 years ago
|
||
This patch proposed will check to see if an end-of-rotation snapping is occurring (by checking for the completeRotation class on the image element), and if so, it will ignore new MozRotateGestureUpdate and MozRotateGesture events.
If the class is not present, the behavior is the same as before.
Attachment #712134 -
Flags: feedback?(jwein)
Assignee | ||
Comment 2•12 years ago
|
||
This bug will be fixed by the patch for bug 840584. Separating the patches was a bit more challenging than it was worth.
Comment 3•12 years ago
|
||
Comment on attachment 712134 [details] [diff] [review]
Propose patch, ignore incoming events until snapping is done
Review of attachment 712134 [details] [diff] [review]:
-----------------------------------------------------------------
I left feedback for this patch in the other bug.
Attachment #712134 -
Flags: feedback?(jwein)
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•