Mats Palmgren (inactive) Reporter
	Description • 12 years ago

STEPS TO REPRODUCE
(warning: the URL is a fuzz tool and it creates (a few) new windows and
may crash your browser)
1. load URL, wait a little while

ACTUAL RESULTS
The test frequently stops waiting for dismissal of this alert.
This is new behavior, I haven't seen these alert windows before
for this test.

	Mats Palmgren (inactive) Reporter
	Comment 1 • 12 years ago

I commented out this line:
http://hg.mozilla.org/mozilla-central/annotate/c1ee454506f6/browser/components/sidebar/nsSidebar.js#l107
that seems to have fixed it.

	Matthew N. [:MattN]
	Comment 2 • 12 years ago

Seems like this is from sidebar code as that's the only use of the string that I see.

https://mxr.mozilla.org/mozilla-central/source/browser/components/sidebar/nsSidebar.js?rev=5ce71981e005&mark=105,107#82

Is the page calling one of the sidebar functions exposed to content such as: window.external.AddSearchProvider("foo")

Calling the above function will reproduce the issue.

	Matthew N. [:MattN]
	Comment 3 • 12 years ago

I mid-air collided with comment 1.
I don't know of any changes in this area so I'm not sure anything needs to be fixed.

	Mats Palmgren (inactive) Reporter
	Comment 4 • 12 years ago

I can't find anything matching "search" (case-insensitive) in this test.
I think it just crawls the script objects and calls everything with random args.

The use of alert() interferes with fuzz testing - can we change it to some other
type of notification?

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 5 • 12 years ago

I'm no fan of any of these APIs or their error handling (see bug 518929 and dependencies), but they're not worth changing solely to satisfy some fuzz tool, I think. Can't you change the tool to avoid window.external/sidebar methods?

	Mats Palmgren (inactive) Reporter
	Comment 6 • 12 years ago

No, it's a third party fuzz tool.  I'll comment out the alert() locally for now.

IMHO, throwing up a modal dialog for the user to deal with just because the script
author made a mistake is a bug.  It might warrant an error message to the console
but I don't see why a user would care about this error at all.

It already does report it to the console so why can't we simply remove lines
101 to 107 ?
http://hg.mozilla.org/mozilla-central/annotate/c1ee454506f6/browser/components/sidebar/nsSidebar.js#l99

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 7 • 12 years ago

Yeah, probably.

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 7 years ago

Is this still an issue?

	Mats Palmgren (inactive) Reporter
	Comment 9 • 7 years ago

Yes, I get "Nightly could not download the search plugin from: <url>" alert prompts.
From here I think:
http://searchfox.org/mozilla-central/rev/1c1a5cef772214e9cff487040ac3068d56e96cc6/toolkit/components/search/nsSearchService.js#1546