Closed
Bug 839831
Opened 12 years ago
Closed 12 years ago
jsjni_ functions should be usable without MOZILLA_INTERNAL_API (e.g. in WebRTC code)
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: dmosedale, Assigned: gcp)
References
Details
(Whiteboard: [android-trunk-needed][android-gum+][qa-])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
Right now, using things like jsjni_FindClass requires including AndroidBridge.h, which blows up because of internal string glop if it's include where MOZILLA_INTERNAL_API isn't defined. gcp put together a patch that puts them in their own files and exports them independently.
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Landed on alder:
https://hg.mozilla.org/projects/alder/rev/fd3a3e5d72e3
Next steps: rebase to trunk and request review.
Whiteboard: [android-trunk-needed]
Reporter | ||
Updated•12 years ago
|
Attachment #712211 -
Attachment description: move jsjni_ functions into their own files, v1 → move jsjni_ functions into their own files, v1 (landed alder)
Reporter | ||
Updated•12 years ago
|
Whiteboard: [android-trunk-needed] → [android-trunk-needed][android-gum+]
Assignee | ||
Comment 3•12 years ago
|
||
Rebased to m-c.
Attachment #712211 -
Attachment is obsolete: true
Attachment #726206 -
Flags: review?(blassey.bugs)
Updated•12 years ago
|
Attachment #726206 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•12 years ago
|
Whiteboard: [android-trunk-needed][android-gum+] → [android-trunk-needed][android-gum+][qa-]
Updated•12 years ago
|
Blocks: android-webrtc
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•