Closed
Bug 840014
Opened 12 years ago
Closed 12 years ago
(tabs) it should be possible to open a private tab
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.14
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
tabs.open({private: true, url: ...}) should open a private tab.
See http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#351
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Target Milestone: --- → 1.14
Assignee | ||
Comment 1•12 years ago
|
||
Hmm, on Fx I guess that default should be to open a tab in a non private window, and only open a tab in a private window if private is true, and ignore the private flag if there is an associated window (ie: require('windows').browserWindows.tabs.open()).
Make sense Irakli?
Flags: needinfo?(rFobic)
Priority: -- → P2
Target Milestone: 1.14 → ---
Comment 2•12 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> Hmm, on Fx I guess that default should be to open a tab in a non private
> window, and only open a tab in a private window if private is true, and
> ignore the private flag if there is an associated window (ie:
> require('windows').browserWindows.tabs.open()).
>
> Make sense Irakli?
Makes sense, although I think we should always open tab in private window if `private: true` is set regardless weather it's called on specific window or not. Ignoring silently in later case can cause more harm IMO.
Flags: needinfo?(rFobic)
Assignee | ||
Comment 3•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #714980 -
Flags: review?(rFobic)
Comment 4•12 years ago
|
||
Comment on attachment 714980 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/797
Looking good, please address comments in pull before landing.
Attachment #714980 -
Flags: review?(rFobic) → review+
Assignee | ||
Updated•12 years ago
|
Blocks: sdk-pwpb-fx21
Comment 5•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/dd39cbfbc23c04cca737fa5b0fdd0eaee61b6f49
Bug 840014: tabs.open() and windows.open() now take a isPrivate option
https://github.com/mozilla/addon-sdk/commit/8135fd0e32e52260ac46067bef8f4b2a8b45d683
bug 840014: checking isPrivateBrowsingSupported before opening a tab in private mode
https://github.com/mozilla/addon-sdk/commit/91d49303b4885c3f6489a840ceab69e2573d3ab2
bug 840014: windows.open with isPrivate: true dnw if private browsing permission is not allowed, and added a fix to tabs.open which would open a private tab in versions of Fennec that have no ptpb ui.
https://github.com/mozilla/addon-sdk/commit/645b982cf6f024862d5bc1277be3263a0834337d
bug 840014: fixing a window and tab test and adding tests of opening non private tabs when private browsing support is enabled
https://github.com/mozilla/addon-sdk/commit/97cc5d12dafe531a3d6aec30c09efeb05b3b4360
bug 840014: link to private-browsing docs from tab and windows docs
https://github.com/mozilla/addon-sdk/commit/ac63592a80d6d316b52b51941434e15feadb0699
Merge pull request #797 from erikvold/840014
Fix Bug 840014: tabs.open() and windows.open() now take a isPrivate option r=@Gozala
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → 1.14
You need to log in
before you can comment on or make changes to this bug.
Description
•