Closed
Bug 84024
Opened 24 years ago
Closed 24 years ago
MFCEmbed Fails to execute form submits
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dunn5557, Assigned: adamlock)
References
Details
(Keywords: smoketest)
MFCEMbed:
ftp://ftp.mozilla.org/pub/mozilla/nightly/2001-06-04-11-trunk/embed-win32.zip
Fails to execute pageloader script.
Steps.
1. Expand MFCEmbed
2. Fire URL: http://jrgm.mcom.com/page-loader/loader.pl
3. Click Sumbit button
Result.
No action executed.
Comment 1•24 years ago
|
||
seen on mfcembed 2001-06-04-11-trunk
this isn't specific to the loadtime test; clicking on any form submit button on
any page get's no response.
Keywords: smoketest
Summary: MFCEmbed Fails to execute pageloader script → MFCEmbed Fails to execute form submits
Comment 2•24 years ago
|
||
yes, it did work Friday. Something broke it since then.
note: gtkEmbed worked okay on today's build
Comment 3•24 years ago
|
||
As a workaround, you can backdoor this test by using this URL:
http://jrgm.mcom.com/page-loader/loader.pl?delay=1000&nocache=0&maxcycle=4
That will start the test immediately, and will bypass the need to do a form
submission (which is there simply for convenience). [But, of course, form
submission should just work].
This looks like its another problem with PSM. winEmbed works more or less but
mfcEmbed doesn't at all. Probably mfcEmbed is unsuccessfully trying to pose it's
own security warning dialogs. I will investigate.
The workaround for the time being is to delete the pipnss.dll and pippki.dll
files and restart. This stops PSM from listening to form submits.
Problem is caused because mfcEmbed does not implement the ConfirmCheck method on
its prompt service. NSS is calling ConfirmCheck on the prompt service to display
the dialog about form submits being insecure blah blah, seeing the not
implemented error that comes back and aborting the submit operation.
http://lxr.mozilla.org/seamonkey/source/embedding/tests/mfcembed/components/Prom
ptService.cpp#163
The fix is to implement this method. Patch follows.
Inline patch is below. Reviews please
Index: mozilla/embedding/tests/mfcembed/components/PromptService.cpp
===================================================================
RCS file:
/cvsroot/mozilla/embedding/tests/mfcembed/components/PromptService.cpp,v
retrieving revision 1.2
diff -u -r1.2 PromptService.cpp
--- PromptService.cpp 2001/05/06 15:03:42 1.2
+++ PromptService.cpp 2001/06/05 17:47:10
@@ -167,7 +167,7 @@
PRBool *checkValue,
PRBool *_retval)
{
- return NS_ERROR_NOT_IMPLEMENTED;
+ return Confirm(parent, dialogTitle, text, _retval);
}
NS_IMETHODIMP CPromptService::Prompt(nsIDOMWindow *parent,
Comment 7•24 years ago
|
||
Looks good to me. r=waterson
Comment 8•24 years ago
|
||
sr=blizzard
Assignee | ||
Comment 10•24 years ago
|
||
Fix is checked in
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 11•24 years ago
|
||
reopening,
now this crashes mfcEmbed as seen on build 2001-06-07-09-trunk
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•24 years ago
|
||
Adam Lock is not reachable. Can somebody else look at this so we can open the
tree soon?
Comment 13•24 years ago
|
||
I'll look at it. May have to do fresh build...
Comment 14•24 years ago
|
||
Build just finished and WFM.
Comment 15•24 years ago
|
||
Can somebody else make this happen? As I said a while ago, WFM.
Comment 16•24 years ago
|
||
my bad....apparently this mornigns testing was loaded over and old version. I
just reran in a clean directory and it works fine...reclosing fixed
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•