Since we have spec'd out listTabs/attachTab now, we should start using them in our tests so that we more closely match how the actual debugger server and client are actually used. Should probably make changes to testactors.js to be more like testcompatactors.js from bug 795368 and use the attachTestTabAndResume helper (from the same bug) instead of attachTestGlobalClientAndResume.

The original protocol specification had a "listContexts" request, but that was only ever implemented in the test harness. The real server has always used a browser-appropriate "listTabs" request. The latter is now documented, and the former has been removed from the spec. This is preparation for using a common root actor implementation for all servers: the xpcshell tests now actually use the protocol such a common root actor would speak.

Try: https://tbpl.mozilla.org/?tree=Try&rev=9e17349a7907

Comment on attachment 745258 [details] [diff] [review] Change debugging server xpcshell tests to use a "listTabs" request, rather than a "listContexts" request. Review of attachment 745258 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/debugger/tests/unit/test_dbgactor.js @@ +19,5 @@ > gClient = new DebuggerClient(transport); > gClient.addListener("connected", function(aEvent, aType, aTraits) { > + gClient.listTabs((aResponse) => { > + do_check_true('tabs' in aResponse); > + for each (let tab in aResponse.tabs) { While you're here can you make that a for..of?

(In reply to Dave Camp (:dcamp) from comment #3) > While you're here can you make that a for..of? Done. https://hg.mozilla.org/integration/mozilla-inbound/rev/f0653eab4d95