Closed
Bug 840407
Opened 12 years ago
Closed 11 years ago
Remove the "align" and "valign" attributes
Categories
(Bugzilla :: User Interface, enhancement)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: chtrom, Assigned: LpSolit)
References
Details
(Keywords: html5)
Attachments
(2 files)
(deleted),
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
Continuing the transition to HTML5, all instances of the "valign" attribute need to be removed. In most places, the valign attribute is being applied to <td> tags and is set to "top".
Reporter | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Severity: normal → enhancement
Reporter | ||
Comment 1•12 years ago
|
||
It looks to me like there are 180 instances of the "valign" attribute in the Bugzilla template files. Of those, 153 of them are used on a <td> tag, 25 are used on a <th> tag, and the last two are used on a <tr> and a <table>.
Assignee | ||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•11 years ago
|
||
"align" is obsolete too and should be removed. This can be done in this bug. Most occurences have been removed thanks to bug 920681 so this is a much simple task now.
Summary: Remove the "valign" attribute → Remove the "align" and "valign" attributes
Assignee | ||
Comment 3•11 years ago
|
||
I'm on it. Almost done.
Assignee: ui → LpSolit
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8355403 -
Flags: review?(justdave)
Comment 5•11 years ago
|
||
Comment on attachment 8355403 [details] [diff] [review]
patch, v1
ok, finally finished going through this, sorry for the delay. I see no major issues with this, and the new version is much more readable. I like. :)
Attachment #8355403 -
Flags: review?(justdave) → review+
Updated•11 years ago
|
Flags: approval+
Assignee | ||
Comment 6•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified skins/contrib/Dusk/global.css
modified skins/standard/admin.css
modified skins/standard/attachment.css
modified skins/standard/buglist.css
modified skins/standard/global.css
modified skins/standard/params.css
modified skins/standard/reports.css
modified skins/standard/search_form.css
modified skins/standard/summarize-time.css
modified template/en/default/account/create.html.tmpl
modified template/en/default/account/prefs/email.html.tmpl
modified template/en/default/account/prefs/permissions.html.tmpl
modified template/en/default/account/prefs/saved-searches.html.tmpl
modified template/en/default/account/prefs/settings.html.tmpl
modified template/en/default/admin/table.html.tmpl
modified template/en/default/admin/components/list.html.tmpl
modified template/en/default/admin/components/select-product.html.tmpl
modified template/en/default/admin/flag-type/confirm-delete.html.tmpl
modified template/en/default/admin/keywords/list.html.tmpl
modified template/en/default/admin/milestones/list.html.tmpl
modified template/en/default/admin/milestones/select-product.html.tmpl
modified template/en/default/admin/params/editparams.html.tmpl
modified template/en/default/admin/params/index.html.tmpl
modified template/en/default/admin/products/list-classifications.html.tmpl
modified template/en/default/admin/products/list.html.tmpl
modified template/en/default/admin/versions/list.html.tmpl
modified template/en/default/admin/versions/select-product.html.tmpl
modified template/en/default/admin/workflow/comment.html.tmpl
modified template/en/default/admin/workflow/edit.html.tmpl
modified template/en/default/attachment/show-multiple.html.tmpl
modified template/en/default/bug/summarize-time.html.tmpl
modified template/en/default/global/choose-classification.html.tmpl
modified template/en/default/global/choose-product.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
modified template/en/default/list/list.html.tmpl
modified template/en/default/reports/chart.html.tmpl
modified template/en/default/reports/create-chart.html.tmpl
modified template/en/default/reports/duplicates.html.tmpl
modified template/en/default/reports/report-table.html.tmpl
modified template/en/default/reports/report.html.tmpl
modified template/en/default/search/search-report-graph.html.tmpl
modified template/en/default/search/search-report-table.html.tmpl
modified template/en/default/whine/mail.html.tmpl
Committed revision 8852.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•11 years ago
|
||
Forgot to fix extensions.
Attachment #8356734 -
Flags: review?(justdave)
Comment 8•11 years ago
|
||
Comment on attachment 8356734 [details] [diff] [review]
fix extensions, v1
works for me, though I wonder about the bug link in voting being changed from center to right... probably not a big deal.
Attachment #8356734 -
Flags: review?(justdave) → review+
Assignee | ||
Comment 9•11 years ago
|
||
The reason for the center -> right change is because bug IDs look better when right-aligned when the number of digits varies.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified extensions/Example/template/en/default/hook/global/footer-end.html.tmpl
modified extensions/Voting/template/en/default/hook/admin/products/edit-common-rows.html.tmpl
modified extensions/Voting/template/en/default/pages/voting/bug.html.tmpl
modified extensions/Voting/template/en/default/pages/voting/user.html.tmpl
modified extensions/Voting/web/style.css
Committed revision 8855.
You need to log in
before you can comment on or make changes to this bug.
Description
•