Closed
Bug 840415
(gmock)
Opened 12 years ago
Closed 12 years ago
Add GMock support to GTest
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 712811 [details] [diff] [review]
gmock + SanityTest
Review of attachment 712811 [details] [diff] [review]:
-----------------------------------------------------------------
Good stuff!
::: testing/gtest/Makefile.in
@@ +72,5 @@
> + gmock/include/gmock/gmock-spec-builders.h \
> + gmock/include/gmock/gmock.h \
> + $(NULL)
> +
> +# gmock also includes internal interfaces in it's public header
nit: its
::: toolkit/content/license.html
@@ +1333,5 @@
>
> <p>This license applies to files in the directories
> <span class="path">toolkit/crashreporter/google-breakpad/</span>,
> <span class="path">testing/gtest/gtest</span>,
> + <span class="path">testing/gtest/gmock</span>,
Not needed.
Attachment #712811 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #712811 -
Attachment is obsolete: true
Attachment #717284 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•