Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Description • 12 years ago

The locations reported by frames over the RDP should be source mapped so that you see the original sources and not the generated sources.

	Rob Campbell [:rc] (:robcee)
	Comment 2 • 11 years ago

marking P2 since it has an assignee.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 3 • 11 years ago

This is implemented in bug 860035, which is just waiting on final review from Jim. We can close this as soon as that lands.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 4 • 11 years ago

Is the attached test in this bug still useful, or is it subsumed in the patch for bug 860035?

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 5 • 11 years ago

browser_dbg_source_maps-03.js tests the first frame via checking the caret position, but there isn't an explicit test for it. I guess we can leave this open, then add the test for more coverage, and close the bug after that.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 6 • 11 years ago

Adds two source mapping related tests (for functionality we already have, but isn't well tested):

1. The frame included in paused packets

2. The list of frames returned from "frames" requests

https://tbpl.mozilla.org/?tree=Try&rev=8169f5bbd5fc

	Victor Porof [:vporof][:vp]
	Comment 7 • 11 years ago

Comment on attachment 789967 [details] [diff] [review]
bug-840684-source-map-frames.patch

Review of attachment 789967 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] Assignee
	Comment 8 • 11 years ago

https://hg.mozilla.org/integration/fx-team/rev/15aaeae89597

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/15aaeae89597