Closed
Bug 840692
Opened 12 years ago
Closed 11 years ago
Use HTTPS instead of HTTP for startup pages (startup.homepage_override_url and startup.homepage_welcome_url)
Categories
(Firefox Graveyard :: Help Documentation, defect)
Firefox Graveyard
Help Documentation
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 24
People
(Reporter: briansmith, Assigned: raymondlee)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #840687 +++
+++ This bug was initially created as a clone of Bug #771788 +++
startup.homepage_override_url;http://www.mozilla.org/projects/%APP%/%VERSION%/whatsnew/?oldversion=%OLD_VERSION%
startup.homepage_welcome_url;http://www.mozilla.org/projects/%APP%/%VERSION%/firstrun/
Since we force users to load these pages at startup, it is even more important that we use https:// URLs for these than for the other URLs given in bug 840687. At the same time, because we load these pages automatically for everybody, we have to make sure we can support the extra load on the HTTPS site.
CC'ing potch since he's the only webdev whose bugzilla nickname I can remember right now.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #720545 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 720545 [details] [diff] [review]
v1
Will change to use mozilla.org as well
Attachment #720545 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 3•12 years ago
|
||
Redirect map:
https://www.mozilla.org/firefox/19.0/whatsnew/ -> https://www.mozilla.org/en-US/firefox/19.0/whatsnew/
https://www.mozilla.org/firefox/19.0/firstrun/ -> https://www.mozilla.org/en-US/firefox/19.0/firstrun/
https://www.mozilla.org/en-US/firefox/19.0/whatsnew/ -> no redirect
https://www.mozilla.org/en-US/firefox/19.0/firstrun/ -> no redirect
Assignee: nobody → raymond
Attachment #720545 -
Attachment is obsolete: true
Attachment #720568 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
Note that this patch conflicts somewhat with bug 486660. We may have to wait to sort that out.
Depends on: 486660
Comment 5•12 years ago
|
||
Comment on attachment 720568 [details] [diff] [review]
v2
Let's take only the browser/branding/official/pref/firefox-branding.js changes (the other changes will need to be removed to avoid a conflict with bug 486660).
Please also change "%app%" to "firefox", per bug 841221 comment 13.
Attachment #720568 -
Flags: review?(gavin.sharp)
Comment 6•12 years ago
|
||
nmaul: this will make the pages opened automatically after Firefox updates hit https://mozilla.org instead of http://mozilla.org. I would like to confirm with someone from IT that this is unlikely to cause any trouble. Can you hook me up with the right person to confirm that, if you're not that person?
Flags: needinfo?(nmaul)
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #720568 -
Attachment is obsolete: true
Attachment #754341 -
Flags: review?(gavin.sharp)
Updated•12 years ago
|
Attachment #754341 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6)
> nmaul: this will make the pages opened automatically after Firefox updates
> hit https://mozilla.org instead of http://mozilla.org. I would like to
> confirm with someone from IT that this is unlikely to cause any trouble. Can
> you hook me up with the right person to confirm that, if you're not that
> person?
Lets wait for info about this before landing the patch.
Assignee | ||
Updated•11 years ago
|
Attachment #754341 -
Attachment is obsolete: true
Comment 9•11 years ago
|
||
According to attachment 754650 [details] [diff] [review], it looks like we're changing from http://www.mozilla.com to https://www.mozilla.org. That's fine, we already redirect from .com to .org anyway, and https:// certainly works.
No concerns here on that change. In fact it'll make things nicer for us, due to less hits overall (avoiding the redirect).
I think, however, that you might want to check with Metrics on this. I know they keep track of /whatsnew/ and /firstrun/ hits, so it would be good to confirm with them that this is a no-op. I'm suspect it is, due to the aforementioned redirect that's already in place, but it would be good to get an authoritative answer just in case they're actually tracking the .com hit. If they are, they'll need some time to adjust.
Anurag (aphadke in IRC) might be a good contact for that.
Flags: needinfo?(nmaul)
Comment 10•11 years ago
|
||
metrics only collects the zeus logs and pushes the logs to DWH, the above switch doesn't involve any change on metrics side of things.
Updated•11 years ago
|
Keywords: checkin-needed
Comment 11•11 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → Firefox 24
Comment 12•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 13•10 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 13.10 and Mac OSX 10.8.5 using latest Nightly 34.0a1.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•