I'm simplifying a lot of our behavior in bug 658909. I've added in various compat shims for common patterns, but there are a few cases that just need to be fixed. I've separated those out into this bug to reduce the traffic in bug 658909.

sandboxPrototype implements fancy rebinding behavior that makes things work right. It is the "correct" mechanism to prototype a sandbox to a DOM Window.

Otherwise, they won't get invoked with the proper |this|.

Comment on attachment 713502 [details] [diff] [review] Use sandboxPrototype rather than __proto__ for marionette sandboxes. v1 Review of attachment 713502 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thanks.

This is yet another piece of broken code that relies on the "find the |this| object" behavior that we're removing. Moreover, it's not caught by our compat hack, because Components.utils is a bizarre object that implements nsIXPCScriptable (giving it a custom JSClass->name that's not XPCWN_NoHelper) while not implementing nsIClassInfo (which would have put the method on the prototype and made this never work in the first place). We _could_ add special support for the Cu JSClass name in our compat hack, but I think we should just fix it here and assume this pattern is not particularly common in external consumers.

Comment on attachment 713527 [details] [diff] [review] Fix up CertUtils. v1 Sorry, I have no idea what is going on in this test or in this bug so somebody else should look at this. Maybe dtownsend?

Comment on attachment 713526 [details] [diff] [review] Fix sandbox xhr tests. v1 Again, I have no idea what is going on here. peterv has the hg blame for this file.

Comment on attachment 713526 [details] [diff] [review] Fix sandbox xhr tests. v1 r=me

Comment on attachment 713527 [details] [diff] [review] Fix up CertUtils. v1 r=me

Comment on attachment 713505 [details] [diff] [review] Bind methods before injecting them in FrameWorker. v1 Review of attachment 713505 [details] [diff] [review]: ----------------------------------------------------------------- Untested, but we have good test coverage of those functions.

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/07a28434afeb remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/6542160e0f5a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c30b8926c2ce remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/78c0b4615cfe

https://hg.mozilla.org/mozilla-central/rev/07a28434afeb https://hg.mozilla.org/mozilla-central/rev/6542160e0f5a https://hg.mozilla.org/mozilla-central/rev/c30b8926c2ce https://hg.mozilla.org/mozilla-central/rev/78c0b4615cfe

We landed only the Marionette specific parts of this in mozilla-b2g18, not the full patch.