Closed
Bug 841642
Opened 12 years ago
Closed 11 years ago
Re-enable WebRTC after bug 837618 is fixed.
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.21
People
(Reporter: ewong, Assigned: mcsmurf)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Callek
:
review+
ewong
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•12 years ago
|
Summary: Re-enable WebRTC after bug bug 837618 is fixed. → Re-enable WebRTC after bug 837618 is fixed.
Assignee | ||
Comment 1•12 years ago
|
||
Bug 837618 has been fixed, we can re-enable webrtc (mostly to fix broken tests for now).
Reporter | ||
Updated•12 years ago
|
Attachment #741345 -
Flags: review?(ewong) → review+
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 741345 [details] [diff] [review]
Patch
Technically speaking, I'm not a build config peer and thusly I can't review this.
I can, however, give a feedback. :) (Sorry Mcsmurf.. )
Attachment #741345 -
Flags: review?(bugspam.Callek)
Attachment #741345 -
Flags: review+
Attachment #741345 -
Flags: feedback+
Comment 3•11 years ago
|
||
Comment on attachment 741345 [details] [diff] [review]
Patch
Review of attachment 741345 [details] [diff] [review]:
-----------------------------------------------------------------
We *probably* need packager changes ala https://bugzilla.mozilla.org/show_bug.cgi?id=839272 -- but for the short-term lets get this in, which may likely help anyway.
Attachment #741345 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
Comment 5•11 years ago
|
||
Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this to Aurora? Just noting here before I forget, because there's now a "WebRTC is now enabled by default" item on the SM 2.19 relnotes that I probably need to revise.
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this
> to Aurora? Just noting here before I forget, because there's now a "WebRTC
> is now enabled by default" item on the SM 2.19 relnotes that I probably need
> to revise.
Sorry Jens, totally missed the bugmail from your comment :(. You're right, WebRTC is not available yet in SeaMonkey. WebRTC core code was/is mainly included to reduce the number of mochitest failures. To get WebRTC itself working in the browser, we need to implement the doorhanger UI so that the user can grant/deny access for mic/cam/etc. (probably the next project I'll work on).
You need to log in
before you can comment on or make changes to this bug.
Description
•