Closed
Bug 841948
Opened 12 years ago
Closed 12 years ago
Flip the pref to enable <input type=range> on Nightly and Aurora
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla22
Tracking | Status | |
---|---|---|
relnote-firefox | --- | - |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
(deleted),
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•12 years ago
|
||
I think we should enable <input type'range'> on Nightly and Aurora as soon as we have an element that has a working DOM and a working layout. No need for a bug-free implementation a native styling.
I think if we open a bug to implement the thumb moving in layout, this bug would depend on all bugs needed to fix it.
Comment 2•12 years ago
|
||
Jonathan, as far as I understand it, the only thing missing to be able to land this the able to move the thumb. Ideally, with the keyboard and the mouse.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #721912 -
Flags: review?(mounir)
Comment 4•12 years ago
|
||
Comment on attachment 721912 [details] [diff] [review]
patch
Review of attachment 721912 [details] [diff] [review]:
-----------------------------------------------------------------
w00t! :)
Attachment #721912 -
Flags: review?(mounir) → review+
Comment 5•12 years ago
|
||
Jonathan, is there a specific reason why you didn't land that patch?
Assignee | ||
Comment 6•12 years ago
|
||
Yes, I specifically want to fix bug 842179 before asking people whether the pseudo-elements meet their needs.
Depends on: 842179
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc80b4d5c4ec
Assuming this sticks and there are no major issues, I'll blog about it to ask for people to test after it reaches latest Nightlies.
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•12 years ago
|
Keywords: dev-doc-needed
Updated•12 years ago
|
relnote-firefox:
--- → ?
Comment 9•12 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130402 Firefox/22.0
BuildID: 20130402004013
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:23.0) Gecko/20130404 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130403 Firefox/23.0
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130403 Firefox/23.0
BuildID: 20130403090950
I verified that the dom.experimental_forms_range pref is "true" in about:config and that the type="range" attribute works without triggering any errors in pages.
Hence marking bug as Verified.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Comment 10•12 years ago
|
||
This bug has been listed as part of the Aurora 22 release notes in either [1], [2], or both. If you find any of the information or wording incorrect in the notes, please email release-mgmt@mozilla.com asap. Thanks!
[1] https://www.mozilla.org/en-US/firefox/22.0a2/auroranotes/
[2] https://www.mozilla.org/en-US/mobile/22.0a2/auroranotes/
Assignee | ||
Comment 11•12 years ago
|
||
Sent this to release-mgmt@:
This bug will most likely not stay enabled for v22. Either the release notes should mention that, or the release notes probably shouldn't mention the feature at all.
Comment 12•12 years ago
|
||
(In reply to Jonathan Watt [:jwatt] from comment #11)
> Sent this to release-mgmt@:
>
> This bug will most likely not stay enabled for v22. Either the release notes
> should mention that, or the release notes probably shouldn't mention the
> feature at all.
Thanks Jonathan - we'll wait to communicate this until it's going to be enabled by default for release users. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•