Currently the music player shows track numbers on all track lists. Track numbers should only be used when when viewing all tracks on a single album and should be based on actual track metadata. If all songs from an album have track # metadata, list them in order and display the track number in the list. For example 1 Song title 2 Song title 3 Song title 4 Song title If all songs from an album are missing track # metadata, list them in alphabetical order and do not display track numbers. For example: Song title Song title Song title Song title If a track is missing from an album, that number will be skipped in the list. For example: 1 Song title 3 Song title 4 Song title 8 Song title If some tracks for an album have the track # metadata and others don't, display the ones with track numbers first, then display the remaining tracks at the end of the list in alphabetical order. For example: 1 Song title 3 Song title 4 Song title 8 Song title Song title Song title Song title

What do you think about grouping albums in the Artist list like so: First Album ------------ 1 First Song 2 Second Song 3 Third Song Second Album ------------ 1 First Song 2 Second Song 3 Third Song That would let us show the track numbers there too, which I think would be useful for finding particular tracks.

Oh, one more thing. If we do this, we should probably support disc number as well. Otherwise, we'll have duplicate track numbers, and sorting will be harder on us.

(In reply to Jim Porter (:squib) from comment #1) > What do you think about grouping albums in the Artist list like so: > > First Album > ------------ > 1 First Song > 2 Second Song > 3 Third Song > > Second Album > ------------ > 1 First Song > 2 Second Song > 3 Third Song > > That would let us show the track numbers there too, which I think would be > useful for finding particular tracks. Hi Jim - My phone shows the album names in the Artist list without track names. But perhaps I'm missing something. :)

I can tack this.

Comment on attachment 8488046 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23961 The PR contains 4 patches. 2 for bug 796305 and two for this bug. The interlocking dependency is the test suite. This is a review request for BOTH bugs. Part 1 for both of the bugs was marged in bug 841949

Comment on attachment 8488046 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23961 Looks good! I have one comment over on GitHub, but it's just advisory (and I feel like I may have made it before...)

noted. even then we should be almost correct. it only matters of there is only the disc 1 on a multi-disc set and that the last track doesn't have the disc-count. I don't it is worth bothering at the moment.

Commits: https://github.com/mozilla-b2g/gaia/commit/9f235c55fcf769a992c110edabf4722bf30d6bd0 https://github.com/mozilla-b2g/gaia/commit/8340525bb062151094eb9dc3e575b7108a971727 Merged in https://github.com/mozilla-b2g/gaia/commit/79333a331b78ba97749f3601e7746b0e83ade7a5

Release Note Request (optional, but appreciated) [Why is this notable]: This is a UI change [Suggested wording]: Indicate the disc number along the track number for a track belonging to a multi-disc set. [Links (documentation, blog post, etc)]: