Closed
Bug 842134
Opened 12 years ago
Closed 12 years ago
"ASSERTION: CSS strings must be quoted"
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jruderman, Assigned: zwol)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files)
testcase
###!!! ASSERTION: CSS strings must be quoted with ' or ": 'quoteChar == '\'' || quoteChar == '"'', file layout/style/nsStyleUtil.cpp, line 63
Regression from bug 543151?
|
Reporter | |
Comment 1•12 years ago
|
||
|
Assignee | |
Comment 2•12 years ago
|
||
Well, this is embarrassing. When I redid the url(...) parser, I forgot to initialize aToken.mSymbol in the unquoted case, so we were getting junk from previous tokens. layout/style mochitests would have caught the problem, but they ignore assertions.
Patch fixes the missing initialization and adds a crashtest based on your test case (I switched it from SVG to HTML).
|
||
Updated•12 years ago
|
Attachment #715000 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1a14e09f50
Thanks for the quick review.
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•