leo+, this bug is needed to fulfill MMS user stories for v1.1

Comment on attachment 722665 [details] [diff] [review] Retry Send MMS Review of attachment 722665 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mms/src/ril/MmsService.js @@ +687,5 @@ > return; > } > > + this.retryCount = 0; > + let that = this; You don't need this. @@ +696,5 @@ > + that.retryCount++; > + let timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer); > + timer.initWithCallback((function (){ > + this.send(retryCallback); > + }).bind(that), let retryCallback = (function (mmsStatus, msg) { if ((MMS.MMS_PDU_ERROR_TRANSIENT_FAILURE == mmsStatus || MMS.MMS_PDU_ERROR_PERMANENT_FAILURE == mmsStatus) && this.retryCount < MAX_RETRY_COUNT) { this.retryCount++; let timer = Cc["@mozilla.org/timer;1"].createInstance(Ci.nsITimer); timer.initWithCallback(this.send.bind(this, retryCallback), DELAY_TIME_TO_RETRY, Ci.nsITimer.TYPE_ONE_SHOT); return; } callbackIfValid(mmsStatus, msg); }).bind(this); this.send(retryCallback); @@ +702,5 @@ > + Ci.nsITimer.TYPE_ONE_SHOT); > + return; > + } > + if (callback) { > + callback(mmsStatus, msg); callbackIfValid instead. @@ +713,5 @@ > + * A callback function that takes two arguments: one for > + * X-Mms-Response-Status, the other for the parsed M-Send.conf message. > + */ > + send: function send(callback) { > + let callbackIfValid = function callbackIfValid(mmsStatus, msg) { You actually pass |retryCallback| to |send|, so the |callback| here is always valid.

Comment on attachment 722707 [details] [diff] [review] Retry Send MMS Review of attachment 722707 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mms/src/ril/MmsService.js @@ +702,5 @@ > + } > + > + callbackIfValid(mmsStatus, msg); > + }).bind(this); > + }, Have you tried it? You missed send() here.

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6) > Comment on attachment 722707 [details] [diff] [review] > Retry Send MMS > > Review of attachment 722707 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/mms/src/ril/MmsService.js > @@ +702,5 @@ > > + } > > + > > + callbackIfValid(mmsStatus, msg); > > + }).bind(this); > > + }, > > Have you tried it? You missed send() here. My bad...orz

Comment on attachment 723326 [details] [diff] [review] Retry Send MMS Review of attachment 723326 [details] [diff] [review]: ----------------------------------------------------------------- Thank you :)

expect to land 3/11