Closed
Bug 842448
Opened 12 years ago
Closed 12 years ago
deprecate window.isPrivateBrowsing
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.14
People
(Reporter: evold, Assigned: ochameau)
References
Details
Attachments
(1 file)
require('private-browsing').isPrivate() should be used instead.
Reporter | ||
Updated•12 years ago
|
Reporter | ||
Updated•12 years ago
|
Blocks: sdk-pwpb-fx21
Priority: -- → P1
Updated•12 years ago
|
Assignee: evold → jgriffiths
Assignee | ||
Comment 1•12 years ago
|
||
It looks like window.isPrivateBrowsing has been introduced by bug 772663 and landed in 1.12, so that two releases have been released with this API and it has even been documented, so that I'd tend to think that we should deprecate it first?
Erik, do you agree about that?
Jeff, do you mind if I provide patch for this?
Comment 2•12 years ago
|
||
(In reply to Alexandre Poirot (:ochameau) from comment #1)
> It looks like window.isPrivateBrowsing has been introduced by bug 772663 and
> landed in 1.12, so that two releases have been released with this API and it
> has even been documented, so that I'd tend to think that we should deprecate
> it first?
>
> Erik, do you agree about that?
>
> Jeff, do you mind if I provide patch for this?
I hadn't realised that it had shipped already, yes we should go the deprecation route instead
Assignee | ||
Updated•12 years ago
|
Assignee: jgriffiths → poirot.alex
Assignee | ||
Comment 3•12 years ago
|
||
I ended up introducing an helper method in order to ease testing deprecated methods and offloaded this task in bug 845549 / PR #816.
Attachment #718674 -
Flags: review?(evold)
Reporter | ||
Updated•12 years ago
|
Attachment #718674 -
Flags: review?(evold) → review+
Comment 4•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/36d4a1f6674b3814878461bc3f68b46491ebe754
Bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate()
https://github.com/mozilla/addon-sdk/commit/e20fb10400ed3a13510d251b1b8fafa6b4eed6f2
Merge pull request #817 from ochameau/window-isprivate
bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate() r=@erikvold
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•11 years ago
|
Summary: remove window.isPrivateBrowsing → deprecate window.isPrivateBrowsing
You need to log in
before you can comment on or make changes to this bug.
Description
•