require('private-browsing').isPrivate() should be used instead.

It looks like window.isPrivateBrowsing has been introduced by bug 772663 and landed in 1.12, so that two releases have been released with this API and it has even been documented, so that I'd tend to think that we should deprecate it first? Erik, do you agree about that? Jeff, do you mind if I provide patch for this?

(In reply to Alexandre Poirot (:ochameau) from comment #1) > It looks like window.isPrivateBrowsing has been introduced by bug 772663 and > landed in 1.12, so that two releases have been released with this API and it > has even been documented, so that I'd tend to think that we should deprecate > it first? > > Erik, do you agree about that? > > Jeff, do you mind if I provide patch for this? I hadn't realised that it had shipped already, yes we should go the deprecation route instead

I ended up introducing an helper method in order to ease testing deprecated methods and offloaded this task in bug 845549 / PR #816.

Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/36d4a1f6674b3814878461bc3f68b46491ebe754 Bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate() https://github.com/mozilla/addon-sdk/commit/e20fb10400ed3a13510d251b1b8fafa6b4eed6f2 Merge pull request #817 from ochameau/window-isprivate bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate() r=@erikvold