Closed Bug 842506 Opened 12 years ago Closed 12 years ago

[Music] Don't update UI when music app is brought to background.

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
1.1 CS (11may)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: dkuo, Assigned: m1)

References

Details

Attachments

(1 file)

In bug 836214, when the screen is off/on, we want to save power by stopping/resuming to listen to timeupdate of audio element in Music app, this depends on a reliable mozvisibilitychange event to achieve. For current b2g, mozvisibilitychange does not dispatched to app if the audio is playing and the screen is off, we probably need to fix this or the timeupdate will keep updating the UI while the screen is off.
Bug 828283 looks extremely wrong to me, and I've commented as such. Thanks for catching this.
(adding tracking-b2g18+ as this causing is a power issue we'd like to see fixed sooner rather than later, ideally in v1.1)
tracking-b2g18: --- → +
Now that bug 853454 has landed, mozvisibilitychange should be dispatched to the music player app when playing w/ screen off right? If so then looks like maybe a patch for this bug is sitting at https://bug836214.bugzilla.mozilla.org/attachment.cgi?id=715860&t=bd5By1ikam
Upgrading bug to leo+ because (1) we have a patch in hand, and (2) power test folks are now flagging this issue.
blocking-b2g: --- → leo+
tracking-b2g18: + → ---
Assignee: nobody → mvines
I hope that for leo, we can have the new AudioChannel API fully implemented. So we can just back port bug 828283.
Bug 828283 has already landed for leo. Did you mean a different bug?
Attached file PR #9495 (deleted) —
This is really just your patch Dominic :)
Attachment #744014 - Flags: review?(dkuo)
Comment on attachment 744014 [details] PR #9495 Looks good, I r+ this because anyone couldn't r+ himself per comment 7.
Attachment #744014 - Flags: review?(dkuo) → review+
Change title to reflect the bug/fix.
Summary: Event "mozvisibilitychange" should be dispatched to app no matter the audio element is playing or not → [Music] Don't update UI when music app is brought to background.
Target Milestone: --- → 1.1 CS (11may)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
John, can you please assist with the v1-train uplift?
Flags: needinfo?(jhford)
v1-train: c449f20f7fbe35b2dded35833e602078bd8eef87
Flags: needinfo?(jhford)
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap-
Depends on: 874288
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: