Closed
Bug 842752
Opened 12 years ago
Closed 12 years ago
js/src/ion/Snapshots.cpp:141:7: warning: variable 'u' set but not used [-Wunused-but-set-variable]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
New build warning in debug builds:
{
js/src/ion/Snapshots.cpp:141:7: warning: variable 'u' set but not used [-Wunused-but-set-variable]
}
Bug 841054 removed the only usage of this variable. Looks like this whole chunk might just want to go away.
|
Assignee | |
Comment 1•12 years ago
|
||
This fixes the warning by removing this apparently no-longer-needed chunk.
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #715787 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 2•12 years ago
|
||
review ping (still seeing this warning in my builds)
Flags: needinfo?(nicolas.b.pierron)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 715787 [details] [diff] [review]
fix
Review of attachment 715787 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/Snapshots.cpp
@@ -139,5 @@
> - RawScript script;
> - uint8_t bytes[sizeof(RawScript)];
> - } u;
> - for (size_t i = 0; i < sizeof(RawScript); i++)
> - u.bytes[i] = reader_.readByte();
You should also remove it from the startFrame function, otherwise no bailout will work anymore and Ion will surely fail the test suite.
Attachment #715787 -
Flags: review?(nicolas.b.pierron)
Flags: needinfo?(nicolas.b.pierron)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Ah, thanks for noticing that. Here's a new patch with that chunk removed as well.
Attachment #715787 -
Attachment is obsolete: true
Attachment #720000 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 5•12 years ago
|
||
I verified that this updated patch passes Try, too, BTW:
https://tbpl.mozilla.org/?tree=Try&rev=2c641f4d8984
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 720000 [details] [diff] [review]
fix v2
Review of attachment 720000 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #720000 -
Flags: review?(nicolas.b.pierron) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Inbound's been closed for most of today, so I just landed on central (which has reopened):
https://hg.mozilla.org/mozilla-central/rev/88c693a603a8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•