Closed
Bug 842924
Opened 12 years ago
Closed 11 years ago
Localization issue with reset period control
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)
Firefox OS Graveyard
Gaia::Cost Control
Tracking
(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)
People
(Reporter: flod, Assigned: salva)
References
Details
(Keywords: l12y, Whiteboard: [LeoVB+])
Attachments
(3 files)
English strings: Monthly, Weekly, Never.
Italian strings: Ogni mese, Ogni settimana, Mai.
Even if I choose to use adverbs it doesn't get shorter (Mensilmente, Settimanalmente).
With the current layout I don't think this is localizable in many languages.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → leo?
Comment 2•11 years ago
|
||
Italian is not a v1.1 language according to internal docs - are you aware of other impacted languages?
blocking-b2g: leo? → -
Reporter | ||
Comment 3•11 years ago
|
||
Some examples that I doubt fit in this design (es, pt-BR, de seem to have shorter strings this time, I wonder if they had to compromise for it)
pl
monthly = Co miesiąc
weekly = Co tydzień
el
monthly = Μηνιαία
weekly = Εβδομαδιαία
nl
monthly = Maandelijks
weekly = Wekelijks
ru
monthly = Ежемесячно
weekly = Еженедельно
Reporter | ||
Comment 4•11 years ago
|
||
Polish screenshot.
Other languages (e.g. pt-BR) has issues with the name of the day (not sure why Polish is using numbers here).
Flags: needinfo?(akeybl)
Reporter | ||
Comment 5•11 years ago
|
||
Requesting again blocking->leo?
blocking-b2g: - → leo?
Flags: needinfo?(akeybl)
Comment 6•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #4)
> Other languages (e.g. pt-BR) has issues with the name of the day (not sure
> why Polish is using numbers here).
It's because in the screenshot, the "monthly" options is selected. If you select "weeky", the names of days don't fit either.
Comment 8•11 years ago
|
||
So what is the desired way of fixing this. Broader select field ?
Reporter | ||
Comment 9•11 years ago
|
||
I guess that's up to the UX team, but for me the only safe way out of this is to have one line for the label and another one for the listbox (we have space below).
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #9)
> I guess that's up to the UX team, but for me the only safe way out of this
> is to have one line for the label and another one for the listbox (we have
> space below).
Sounds nice to me. Trying to sync with UX to achieve the best result for this strategy.
Assignee: nobody → salva
Comment 11•11 years ago
|
||
Hi guys,
we had a similar problem in the clock app when setting up the alarms, so we decided to do a small update to these buttons. Basically we should not be using the small buttons aligned to the right. The problem, as you've been suffering, is that it's really difficult to fit any value within a button that small, so we decided to go with a regular button containing the value with a label on top of it.
You can check the visuals through this link: https://bug867038.bugzilla.mozilla.org/attachment.cgi?id=750660
Thanks!
Comment 12•11 years ago
|
||
when is the patch expected to land for this?
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to Sergi from comment #11)
> Hi guys,
>
> we had a similar problem in the clock app when setting up the alarms, so we
> decided to do a small update to these buttons. Basically we should not be
> using the small buttons aligned to the right. The problem, as you've been
> suffering, is that it's really difficult to fit any value within a button
> that small, so we decided to go with a regular button containing the value
> with a label on top of it.
>
> You can check the visuals through this link:
> https://bug867038.bugzilla.mozilla.org/attachment.cgi?id=750660
>
> Thanks!
Thank you very much Sergi!
(In reply to chris hofmann from comment #12)
> when is the patch expected to land for this?
This weekend.
Assignee | ||
Comment 14•11 years ago
|
||
Attachment #771977 -
Flags: review?(francisco.jordano)
Comment 15•11 years ago
|
||
Comment on attachment 771977 [details]
Avoid l10n issues by providing wider selects
Simple and non risky change,
Thanks Salva!
Attachment #771977 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 16•11 years ago
|
||
Master: 89d2ec965d3c7422359ca383b40c26a738610ba3
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 17•11 years ago
|
||
Is this going to land on v1 train as well?
Assignee | ||
Comment 18•11 years ago
|
||
It should, it is leo+
Comment 19•11 years ago
|
||
Uplifted 89d2ec965d3c7422359ca383b40c26a738610ba3 to:
v1-train: 322435efe0e69bc0b19982f6cc4e02964426cff3
status-b2g18:
--- → fixed
Comment 20•11 years ago
|
||
Can you please provide steps to verify this fix.
Comment 21•11 years ago
|
||
Verified, fixed on leo Moz RIL
Environmental Variables
Build ID: 20130723070209
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: ffe25bfdf0e71c820ca710cb61fb8306564a8f4e
Platform Version: 18.1
Issue does not reproduce reset period control is not too narrow and fits all the string into the textbox ... please ignore comment 20
Comment 22•11 years ago
|
||
v1.1.0hd: 322435efe0e69bc0b19982f6cc4e02964426cff3
status-b2g-v1.1hd:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•