Closed Bug 843231 Opened 12 years ago Closed 12 years ago

Compute whether to use XBL scopes exactly once

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22
Tracking Flags:
Tracking Status
firefox21 --- fixed
firefox22 --- fixed

People

(Reporter: bholley, Assigned: bholley)

Details

Attachments

(4 files)

Part 1 - Move the nulling out of mPrototypeNoHelper from SetGlobal to RemoveWrappedNativeProtos. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part 2 - Remove SetGlobalObject. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part 3 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part 4 - Compute whether to use an XBL scope exactly once. v1
(deleted), patch
bzbarsky
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
This will let us avoid doing work in certain cases, and reduces the refactoring required to define Components on the XBL scope.
The only call-site for both of these is JSD->nsXPConnect::InitClasses, so this is equivalent. All this will go away soon anyhow when JSD goes away.
Attachment #716152 - Flags: review?(bzbarsky)
This stuff has all been simplified significantly with CPG, and this is no longer necessary. We always have a global when we construct a scope, and it never changes.
Attachment #716153 - Flags: review?(bzbarsky)
Attachment #716156 - Flags: review?(bzbarsky)
I figured out a simpler way to do the Components stuff so this no longer blocks, but it's a good thing to do anyway.
No longer blocks: 790732
Comment on attachment 716152 [details] [diff] [review] Part 1 - Move the nulling out of mPrototypeNoHelper from SetGlobal to RemoveWrappedNativeProtos. v1 r=me
Attachment #716152 - Flags: review?(bzbarsky) → review+
Comment on attachment 716153 [details] [diff] [review] Part 2 - Remove SetGlobalObject. v1 It's called SetGlobal, not SetGlobalObject. r=me with that, I guess.
Attachment #716153 - Flags: review?(bzbarsky) → review+
Comment on attachment 716155 [details] [diff] [review] Part 3 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. v1 r=me
Attachment #716155 - Flags: review?(bzbarsky) → review+
Comment on attachment 716156 [details] [diff] [review] Part 4 - Compute whether to use an XBL scope exactly once. v1 r=me
Attachment #716156 - Flags: review?(bzbarsky) → review+
Comment on attachment 716156 [details] [diff] [review] Part 4 - Compute whether to use an XBL scope exactly once. v1 See bug 844783 comment 53.
Attachment #716156 - Flags: approval-mozilla-aurora?
Whiteboard: [leave uplift for bholley]
Attachment #716156 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [leave uplift for bholley]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: