Closed
Bug 843337
Opened 12 years ago
Closed 12 years ago
GC: no need for getAllocKind in JSObject::finalize
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: terrence, Assigned: terrence)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
We used to have to check the background finalization kind before getting the class because the class is stored behind the shape. Since bug 838643, this is no longer necessary. This is good, because I am making getAllocKind slower in 841059. That bug regresses v8-early-boyer without this patch also applied.
Attachment #716227 -
Flags: review?(jcoppeard)
|
||
Updated•12 years ago
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #716227 -
Attachment is obsolete: true
Attachment #716227 -
Flags: review?(jcoppeard)
Attachment #716236 -
Flags: review?(jcoppeard)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 716236 [details] [diff] [review]
v1: This time working in debug builds too.
Review of attachment 716236 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
This is similar to some changes I was doing in bug 841801 anyway, but this looks like it will land first.
Attachment #716236 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Yeah, I saw it just a few minutes after I put this patch up for review. Sorry for busting your next merge. :-)
https://hg.mozilla.org/integration/mozilla-inbound/rev/710cfe8fed89
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•