Closed
Bug 843921
Opened 12 years ago
Closed 11 years ago
[Homescreen] Remove deviceStorage permission
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pauljt, Assigned: joshua-s)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
crdlc
:
review+
|
Details | Diff | Splinter Review |
The homescreen app manifest requests the 'device-storage:pictures":{ "access": "readonly" }' permission - but as far as I can tell, it never uses this permission. I am guessing it was used to get images for wallpaper, but now this is done via web activities and stored in a setting.
Can we remove this permission if it is no longer used?
In terms of risk, leaving the permission in isn't really much of a risk - the homescreen has, by necessity, much more powerful permissions (settings-write etc). This is really just a best practice/housekeeping recommendation.
|
Assignee | |
Comment 1•11 years ago
|
||
I'll fix this.
Assignee: nobody → joshua-smith
Severity: normal → minor
OS: Mac OS X → All
Hardware: x86 → All
|
|
Assignee | |
Updated•11 years ago
|
Summary: Remove the devicestorage permission from the homescreen → [Homescreen] Remove deviceStorage permission
|
||
Comment 3•11 years ago
|
||
Comment on attachment 758025 [details] [diff] [review]
GitHub: https://github.com/mozilla-b2g/gaia/pull/10191
Great!! Less permissions
Attachment #758025 -
Flags: review? → review+
|
Reporter | |
Updated•11 years ago
|
Blocks: b2gGaiaSecurity
|
||
Comment 4•11 years ago
|
||
Got R+ a while ago, finally landed in master: https://github.com/mozilla-b2g/gaia/commit/febd3b9acc563d5420ec832cf455d7b669d02d21
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•