Closed
Bug 844054
Opened 12 years ago
Closed 12 years ago
[SMS/MMS] Activity to Add Phone number to existing Contacts
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect, P1)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
People
(Reporter: ssaroha, Assigned: alberto.pastor)
References
()
Details
(Keywords: feature, Whiteboard: [LOE:M])
Attachments
(2 files)
Creating a separate bug to track the Contact Activity related changes needed for SMS feature in bug 838000.
Attachment #717064 -
Flags: review?(alberto.pastor)
Updated•12 years ago
|
Assignee: nobody → ssaroha
Updated•12 years ago
|
Whiteboard: u=aganesan@mozilla.com c=sms s=v1.1-sprint-1 [LOE:M]=3-4 days → u=aganesan@mozilla.com c=sms s=v1.1-sprint-1 [LOE:M]
Comment 2•12 years ago
|
||
satender:
This already exists (even though there are some UX issues with it). When someone sends/receives a message from an unknown number, they can tap on the number and it will go to the 'add contact' screen with that number filled in. I just wanted to point that out here.
The ability to add to an existing contact is missing here, (amongst many other things.) I will wait for Casey to chip in here before I figure out everything necessary for the specs.
Comment 3•12 years ago
|
||
satender:
edit: this does not exist (but something related which is adding as a new contact exists).
Cheers,
Arun
Whiteboard: u=aganesan@mozilla.com c=sms s=v1.1-sprint-1 [LOE:M] → [LOE:M]
Comment 4•12 years ago
|
||
Specs:
https://www.dropbox.com/s/idm193hxs0nrbet/saving-sms-contacts.pdf
thoughts?
Whiteboard: [LOE:M] → u=aganesan@mozilla.com c=sms s=v1.1-sprint-1 [LOE:M]
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Arun Balachandran Ganesan [:abc] from comment #3)
> satender:
>
> edit: this does not exist (but something related which is adding as a new
> contact exists).
>
> Cheers,
> Arun
That's the point. This bug is adding 'Add to exising contact' as an activity.
Thanks!
Assignee | ||
Comment 6•12 years ago
|
||
Could you please take a look to my comments on the PR?
Thanks!
Flags: needinfo?(ssaroha)
Comment 7•12 years ago
|
||
(In reply to Arun Balachandran Ganesan [:abc] from comment #4)
> Specs:
>
> https://www.dropbox.com/s/idm193hxs0nrbet/saving-sms-contacts.pdf
>
> thoughts?
Hi Arun
I have just reviewed the wireframes that you have appended in comment #4 and form a UX perspective have a couple of point that i would like clarifying:
--overall--
1) Why does the flow stop a the' call, create new, add to existing' dialogue options? should we not have the flow fully articulated / thought through.
--first wireframe--
2) Why do you specify the phone number appearing twice? once in the header and once in the sub header? There is a bit of information redundancy here.
3) Why is there a compose message icon in the top right hand corner of a screen that is in compose message mode?
4) Where is the CTA for MMS? This bug covers MMS and i do not see it considered in the wireframes.
5) Do you propose a 'one size fits all' or would you suggest different architectural solutions for:
- unknown contact (contact not in contact list)
- known contact (contact is in contact list)
6) How do you propose to handle group messaging?
--second wireframe--
7) Do you propose a 'one size fits all' or would you suggest different architectural solutions for:
- unknown contact (contact not in contact list)
- known contact (contact is in contact list)
Thanks
Updated•12 years ago
|
Flags: needinfo?(aganesan)
Arun/ayman,
This bug is to purely address the backend work of creating backend "webactivity" needed for implementing the features in bug 838000 and bug 838002. This was purely created to ease the review process.
the actual UX doc from Casey/Arun and subsequent discussion is there in those bugs.
I hope this clarifies the confusion.
Alberto,
I will address the review comments today.
Thanks
Satender
Flags: needinfo?(ssaroha)
Assignee | ||
Updated•12 years ago
|
Assignee: ssaroha → alberto.pastor
Assignee | ||
Comment 9•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #718981 -
Flags: review?(ssaroha)
Attachment #718981 -
Flags: review?(francisco.jordano)
Comment 10•12 years ago
|
||
Comment on attachment 718981 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8362
Some minor comments on the PR, but r+ once that are addressed.
Good work!
Attachment #718981 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 13•12 years ago
|
||
Rob's working on it. Tagging him here.
Updated•12 years ago
|
Flags: needinfo?(rmacdonald)
Updated•12 years ago
|
Whiteboard: u=aganesan@mozilla.com c=sms s=v1.1-sprint-1 [LOE:M] → [LOE:M]
Comment 14•12 years ago
|
||
Casey is tracking down the user story for this item.
Flags: needinfo?(rmacdonald)
Comment 15•12 years ago
|
||
Removing [User Story] from summary to avoid confusion (as this is a sub component of the parent user story, not an actual user story).
Blocks: 838020
Summary: [SMS/MMS][User Story] Activity to Add Phone number to existing Contacts → [SMS/MMS] Activity to Add Phone number to existing Contacts
Comment 16•12 years ago
|
||
Uplifted commit 90812b24da13deef77012d6ee38351bbbbb5520b as:
v1-train: e8119e0a6c2897a4232ee581a05a6760158d3898
status-b2g18:
--- → fixed
Comment 17•12 years ago
|
||
Either TEF or Taipei owns this.
Do we know who is adding test coverage for this?
Flags: needinfo?(tchung)
Flags: in-moztrap?
Updated•12 years ago
|
Flags: needinfo?(tchung)
Comment 18•12 years ago
|
||
Telefonica is adding the test coverage(In reply to Jason Smith [:jsmith] from comment #17)
> Either TEF or Taipei owns this.
>
> Do we know who is adding test coverage for this?
Telefonica is adding the test coverage
Assignee | ||
Updated•12 years ago
|
Attachment #718981 -
Flags: review?(ssaroha)
Assignee | ||
Updated•12 years ago
|
Attachment #717064 -
Flags: review?(alberto.pastor)
Flags: in-moztrap? → in-moztrap+
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•