Closed
Bug 844219
Opened 12 years ago
Closed 12 years ago
installing again an uninstalled packaged app is not displaying correctly the size
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g18 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | --- | fixed |
People
(Reporter: jsmith, Assigned: julienw)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
etienne
:
review+
vingtetun
:
approval-gaia-v1+
|
Details | Diff | Splinter Review |
Build: B2G 18 2/22/2013
Device: Unagi
Note - Make sure you have a clean flashed build.
Steps:
1. Go to https://marketplace.firefox.com/app/sportv-futebol/
2. Install it - notice the download progress is determinate
3. Uninstall the app
4. Install that app again
Expected:
The download progress should be determinate in this case, as we know the size of the download.
Actual:
The download progress is indeterminate, even though we know the size of the download.
Additional Notes:
This is the bug I've been tried narrowing down for a while, but I finally got a consistent STR.
|
Reporter | |
Updated•12 years ago
|
Blocks: app-install
Component: General → Gaia::System
|
Assignee | |
Comment 1•12 years ago
|
||
I think it happens with every packaged app with a size, and I may have a patch soon.
|
|
Assignee | |
Updated•12 years ago
|
Summary: Installing SporTV Futebol and completing the download, uninstall it, try installing it again - download progress is indeterminate → installing again an uninstalled app is not displaying correctly the size
|
|
Assignee | |
Comment 2•12 years ago
|
||
- use updateManifest.size if there is an updateManifest, use manifest for the
other properties if manifest is present
---
apps/system/js/app_install_manager.js | 9 ++-
apps/system/test/unit/app_install_manager_test.js | 63 +++++++++++++++++++++
2 files changed, 67 insertions(+), 5 deletions(-)
Asking for approval too : low risk, lots of unit tests, added some unit tests for this case too.
Assignee: nobody → felash
Attachment #719684 -
Flags: review?(etienne)
Attachment #719684 -
Flags: approval-gaia-v1?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #719684 -
Flags: approval-gaia-v1? → approval-gaia-v1?(21)
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite+
|
|
Assignee | |
Comment 3•12 years ago
|
||
STR:
* install app in http://everlong.org/mozilla/selfupdatingpackaged/
* see in the notification panel that there is a determinate progress bar
* uninstall the app (no need to wait that it is installed)
* install the app again
* see in the notification panel that there is now an indeterminate a progress bar whereas it should be determined
Summary: installing again an uninstalled app is not displaying correctly the size → installing again an uninstalled packaged app is not displaying correctly the size
|
||
Updated•12 years ago
|
Attachment #719684 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Comment on attachment 719684 [details] [diff] [review]
patch v1
small changes with tests! <3
Attachment #719684 -
Flags: approval-gaia-v1?(21) → approval-gaia-v1+
|
||
Comment 6•12 years ago
|
||
Uplifted commit 8b955ec03bb86187e2a21c5d24c0ff06e35324cb as:
v1-train: c2d63f7aac31bc35dec9c22224fe61bd5ee53853
|
|
||
Comment 7•12 years ago
|
||
(In reply to John Ford [:jhford] from comment #6)
> Uplifted commit 8b955ec03bb86187e2a21c5d24c0ff06e35324cb as:
> v1-train: c2d63f7aac31bc35dec9c22224fe61bd5ee53853
sorry, wrong tab.
|
|
||
Comment 8•12 years ago
|
||
Uplifted commit 7f0a1d5341ac8870e70f64f543ec79a729bf717e as:
v1-train: 897f3b9ca9490cdddc9407033115b65cfcacf373
You need to log in
before you can comment on or make changes to this bug.
Description
•