+++ This bug was initially created as a clone of Bug #792021 +++ Comment on attachment 709778 [details] [diff] [review] [diff] [review] patch v2 Okay, ui-r=me, but I'ld like you to file a couple of followup bugs, if you don't mind. 1) The cut/copy/paste icons don't have a hover state, and I think they should act more like the ▶ icon.

Blake, I take you for reviews because you wanted this and I think it's the best you check this. I've added white icons when in hover state. Additionally I removed the margins around the icons to make the edit menu only 18px tall (minimal icon height) and not 22px as before. the original menus are 17px tall.

Screenshot for easier review

Comment on attachment 717489 [details] [diff] [review] proposed fix While I appreciate that the background on hover is now the same height as the disclosure arrows, the cut/copy/paste icons seem to be pushing up against the edges a little now… Is there any way you could make smaller icons for those? I suspect the answer might be "No", so I'm going to say ui-r=me, even with the larger icons, so that this can move forward, but if you could make smaller icons, I think that would look nicer… And the code seems fine, so r=me, as well. Thanks, Blake.

My bad, I haven't realised the icons where already 16px (the glyphs are 14px with 1px around them) and drawn as 18px through the .toolbarbutton-icon rule. This patches fixes it to 16px with 1px margin. This lets this menu 18px tall but gives 2px space for the highlight background. What do you think, is this a candidate to land on ESR because it fixes also the wrong icon dimensions?

I don't mark attachment 717490 [details] as obsolete for a better comparison of the space around the glyphs.

Comment on attachment 717611 [details] [diff] [review] proposed fix v2 r=me, ui-r=me! I'm not sure about landing it in the ESR… Hopefully Standard8 or Irving will weigh in. Thanks, Blake.

Comment on attachment 717611 [details] [diff] [review] proposed fix v2 [Triage Comment] I think we possibly could take this on esr, but lets get some testing on aurora/beta first.