Closed
Bug 844497
Opened 12 years ago
Closed 12 years ago
Open Location dialog should not save state when opened in a private window
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.18 fixed)
RESOLVED
FIXED
seamonkey2.19
| Tracking | Status | |
|---|---|---|
| seamonkey2.18 | --- | fixed |
People
(Reporter: neil, Assigned: neil)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The open location dialog never saves state when you use it to open a new private window. Except in that case, if open it from a private window it still saves state.
|
Assignee | |
Comment 1•12 years ago
|
||
The other alternative would be to make private be "5", but I think that results in a slightly bigger patch.
(In reply to neil@parkwaycc.co.uk from comment #1)
> Created attachment 717536 [details] [diff] [review]
> Possible patch
>
> The other alternative would be to make private be "5", but I think that
> results in a slightly bigger patch.
I think my preference would be to have "5" being private.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Unfortunately making private "5" messes up the nice numbering in ComposerCommands.js and navigator.js ;-)
Attachment #717539 -
Flags: review?(iann_bugzilla)
Comment on attachment 717536 [details] [diff] [review]
Possible patch
Hmmm, I agree this one is better.
Attachment #717536 -
Flags: review?(iann_bugzilla) → review+
Attachment #717539 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
status-seamonkey2.18:
--- → affected
Target Milestone: --- → seamonkey2.19
|
|
Assignee | |
Comment 6•12 years ago
|
||
Comment on attachment 717536 [details] [diff] [review]
Possible patch
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Potential information leak
Testing completed (on m-c, etc.): Uplifted to c-a
Risk to taking this patch (and alternatives if risky):
String changes made by this patch: None
Attachment #717536 -
Flags: approval-comm-beta?
Attachment #717536 -
Flags: approval-comm-beta? → approval-comm-beta+
|
|
Assignee | |
Comment 7•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•