Closed
Bug 844683
Opened 12 years ago
Closed 12 years ago
scoped-style-pseudo-001.html and scoped-style-pseudo-002.html will fail on the next merge to mozilla-beta
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
Tracking | Status | |
---|---|---|
firefox21 | --- | fixed |
People
(Reporter: philor, Assigned: heycam)
References
Details
Attachments
(1 file)
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/?tree=Try&rev=5d630e18ce25 is the current mozilla-aurora pushed to try roughly as though it were mozilla-beta, saying that if we merged today, we'd wind up with permaorange in scoped-style-pseudo-001.html and scoped-style-pseudo-002.html.
Reporter | ||
Comment 1•12 years ago
|
||
Hmm, and https://tbpl.mozilla.org/?tree=Try&rev=ada886f11c52 is aurora with only the update channel set to beta, but without changing the version from 21.0a2 to 21.0, and without the branding changes, passing those tests.
Comment 2•12 years ago
|
||
Ah, indeed, the version bump is the key, rather than the update channel, since all.js has:
// Is support for the :scope selector enabled?
#ifdef RELEASE_BUILD
pref("layout.css.scope-pseudo.enabled", false);
#else
pref("layout.css.scope-pseudo.enabled", true);
#endif
and http://hg.mozilla.org/mozilla-central/file/e48e1afb1899/config/rules.mk#l1229 has:
# Set a flag that can be used in pref files to disable features if
# we are not building for Aurora or Nightly.
ifeq (,$(findstring a,$(GRE_MILESTONE)))
PREF_PPFLAGS += -DRELEASE_BUILD
endif
which makes this expected. I seem to have misremembered how RELEASE_BUILD was set.
Reporter | ||
Comment 3•12 years ago
|
||
Tick tick tick, the merge clock is running, two weeks until this will be causing permaorange on mozilla-beta.
Assignee | ||
Comment 4•12 years ago
|
||
I'll look at this in a week.
Assignee: nobody → cam
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•12 years ago
|
||
Set the pref to enable :scope for these tests, as well as scoped-style-pseudo-003.html which doesn't actually fail but which does use :scope too.
Attachment #728809 -
Flags: review?(philringnalda)
Reporter | ||
Comment 6•12 years ago
|
||
Comment on attachment 728809 [details] [diff] [review]
patch
r=me (though =tryserver would be more accurate), a=test-only, shipit!
Attachment #728809 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment 9•12 years ago
|
||
Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/286f3ec182e8
status-firefox21:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•