Pittaya Sroilong Reporter
	Description • 12 years ago

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130222 Firefox/21.0
Build ID: 20130222111254

Steps to reproduce:

Try to type in Thai (th).


Actual results:

No Thai input method.


Expected results:

Thai should be available to select in Settings > Keyboard and in keyboard layout switcher.

	Pittaya Sroilong Reporter
	Comment 1 • 12 years ago

Pull request from Github https://github.com/mozilla-b2g/gaia/pull/8289

	Dietrich Ayala (:dietrich)
	Comment 2 • 12 years ago

Cc'ing people who'd know the right reviewer and who might have input.

	Axel Hecht [:Pike]
	Comment 3 • 12 years ago

Not sure how and when to drive this forward, but we'll need a bugzilla attachment pointing to the PR. Just a short html file redirecting to the actual PR url. Then request review from someone that contributed to keyboard before.

	Walter Chen[:ypwalter][:wachen]
	Comment 5 • 11 years ago

Kevin Scannell might know more about this.

I think this also provide a little bit more information on this:
https://wiki.mozilla.org/L10n:B2G/Adding_Locales

	Kevin Scannell
	Comment 6 • 11 years ago

I can provide frequency information for Thai if needed, just ping me.  Don't know about the rest of the process, however.

	Walter Chen[:ypwalter][:wachen]
	Comment 7 • 11 years ago

Kevin, sorry for the bothering :P
I don't know who to ping actually :P

And, thanks for the helping!

	arky [:arky]
	Comment 8 • 11 years ago

Any feedback on this patch.

	David Flanagan [:djf]
	Comment 10 • 11 years ago

Vee,

Thank you for this patch!  The next step is to get it reviewed.  Rudy Lu and I are both potential reviewers.

There is a general problem with new keyboard layouts.  We want to have lots available for users around the world. But we don't want to keep adding layouts to the default build. (This is especially problematic if the layouts have associated autocorrect dictionaries).

Your patch will be much easier to land once bug 884754 is resolved and there is a way to configure the list of supported keyboards at build time.

Meanwhile, in comment 6, Kevin has volunteered to provide an autocorrect wordlist for Thai.  If he does this, you might be able to get Thai autocorrection basically for free. Perhaps you and Kevin and I should talk about this: does Thai have tricky parts like vowels as diacritcs or combining forms where two letters produce a ligature?  If it works pretty much like a latin alphabet, then maybe we can use the (increasingly misnamed) latin IM for it.  (Note that the title of this bug is now out of date.  The title specifies an "input method" and the patch just adds a keyboard layout.)

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 11 • 11 years ago

As commented on github, https://github.com/mozilla-b2g/gaia/pull/12239#issuecomment-24561488,

I think we can accept this patch into our built-in keyobard app if simply adding the layout could serve most of Thai speakers.
If they would need more than that, e.g. a dictionary for auto correction or something for them to input Thai, then we would suggest we move it into a separate app.

Vee,

Could you confirm what we need here?
Thank you.

	Vee Satayamas
	Comment 12 • 11 years ago

You're welcome. Auto correction for Thai is a bit different from languages using latin alphabet because there is no explicit marker (space) between Thai words. In Thai (like Myanmar, Khmer, etc), space is usually used for indicating larger unit than word e.g. phrases, clause. So I don't think, using latin IM without modification is possible.

> Vee,
> 
> Thank you for this patch!  The next step is to get it reviewed.  Rudy Lu and
> I are both potential reviewers.
> 
> There is a general problem with new keyboard layouts.  We want to have lots
> available for users around the world. But we don't want to keep adding
> layouts to the default build. (This is especially problematic if the layouts
> have associated autocorrect dictionaries).
> 
> Your patch will be much easier to land once bug 884754 is resolved and there
> is a way to configure the list of supported keyboards at build time.
> 
> Meanwhile, in comment 6, Kevin has volunteered to provide an autocorrect
> wordlist for Thai.  If he does this, you might be able to get Thai
> autocorrection basically for free. Perhaps you and Kevin and I should talk
> about this: does Thai have tricky parts like vowels as diacritcs or
> combining forms where two letters produce a ligature?  If it works pretty
> much like a latin alphabet, then maybe we can use the (increasingly
> misnamed) latin IM for it.  (Note that the title of this bug is now out of
> date.  The title specifies an "input method" and the patch just adds a
> keyboard layout.)

	Vee Satayamas
	Comment 13 • 11 years ago

The layout only without auto correction is already enough. As far as, I have seen Thai people use smartphones, they turn auto correction off even if it is available (for example, on iOS). For more example, one of the most popular Thai keyboard apps on Android, in Keyboard Manman even doesn't provide  auto correction.

(In reply to Rudy Lu [:rudyl] from comment #11)
> As commented on github,
> https://github.com/mozilla-b2g/gaia/pull/12239#issuecomment-24561488,
> 
> I think we can accept this patch into our built-in keyobard app if simply
> adding the layout could serve most of Thai speakers.
> If they would need more than that, e.g. a dictionary for auto correction or
> something for them to input Thai, then we would suggest we move it into a
> separate app.
> 
> Vee,
> 
> Could you confirm what we need here?
> Thank you.

	pure.gif
	Comment 14 • 11 years ago

pull request thai layout 
https://github.com/mozilla-b2g/gaia/pull/15500

	Ahmed Nefzaoui [:Nefzaoui]
	Comment 15 • 11 years ago

Humm, I was curious enough to test out Pure's latest patch. Therefore something seems wrong.

"secondLayout" (which stands for making the upperCase layout an extra space for more characters) is not working when using Rocketbar with imEngine set to 'latin' in the layout file, tried removing it and it worked, it was so obvious that, the issue was caused because this is not a latin language. Same as Myanmar and Arabic.
However secondLayout in Myanmar is working well on Rocketbar which confused me.
Arky, can you please confirm the existence this particular issue? :)
Thanks

	arky [:arky]
	Comment 16 • 11 years ago

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #15)
> Arky, can you please confirm the existence this particular issue? :)

No idea, I think the patch is stale anyway.

	Greg Green Assignee
	Comment 17 • 10 years ago

I have updated this keyboard from the previous versions submitted on the bug.

	Sudheesh Singanamalla (:ShellHacker)
	Comment 18 • 10 years ago

Greg, Could you squash the commits and push it as just one commit ?

	Greg Green Assignee
	Comment 19 • 10 years ago

Squashed the commits in branch

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 20 • 10 years ago

Comment on attachment 8543380 [details]
pull request for thai keyboard

This patch would still need some updates to make it conform to our latest format of the layout definition.
Please help take a look at the comments I made on the pull request and let me know if you have any updates on this.

Thanks and sorry for the delay to look at your patch.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 21 • 10 years ago

Assign to Greg since he is working on this.

	Greg Green Assignee
	Comment 22 • 10 years ago

rudyl,

Thanks for the review, I will incorporate your comments.

	Greg Green Assignee
	Comment 23 • 10 years ago

rudyl: The keyboard layout now uses pages. Removed the symbol page as the default one is ok. Removed spaces near commas.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 24 • 10 years ago

Comment on attachment 8549391 [details]
pull request for thai keyboard

Hi this looks good with some nits to be addressed.
Thank you very much.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 26 • 10 years ago

I noticed that you add "R=gpgreen@gmail.com", you should remove this.
Our convention is use "r=email_of_your_reviewer" in the merge commit, so you don't have to add this info here and it should not be your own name.

	Greg Green Assignee
	Comment 27 • 10 years ago

(In reply to Rudy Lu [:rudyl] from comment #26)
> I noticed that you add "R=gpgreen@gmail.com", you should remove this.
> Our convention is use "r=email_of_your_reviewer" in the merge commit, so you
> don't have to add this info here and it should not be your own name.

I followed the procedure on this link: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch, step 3. Is there somewhere else that describes what you are asking? I suspect there are other things I need to know...

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 28 • 10 years ago

No, that's correct reference, I think.
but here r means review, you could put r=rudylu here, instead of your own name.

Thanks.

	Greg Green Assignee
	Comment 29 • 10 years ago

Rudy,

I have updated the pull request.

	Greg Green Assignee
	Comment 30 • 10 years ago

Comment on attachment 8549391 [details]
pull request for thai keyboard

Updated pull request to squash commits.

	Rudy Lu [:rudyl] (inactive after 2015/7/3)
	Comment 31 • 10 years ago

Comment on attachment 8549391 [details]
pull request for thai keyboard

Looks good to me.
Thank you!

Will try to land this after CI is passed.

	Ryan VanderMeulen [:RyanVM]
	Comment 32 • 10 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/5ecbc9cdb7cc2a53b594c22b0608bed1cfa805a9

	Pi Wei Cheng [:piwei] (inactive)
	Comment 33 • 10 years ago

Thai keyboard is still NOT available on Settings > Keyboards > Select Keyboards list.

See screenshot. The two options not in the screenshot are English and Number.

Tested on latest Central for which I've verified this build contains the Gaia change at comment 32.

Device: Flame 3.0 Master
BuildID: 20150121141532
Gaia: 917b6c36717fddc6e71ffc1ec249633c8044c93c
Gecko: 06b590bf59f4
Version: 38.0a1 (3.0 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

	Greg Green Assignee
	Comment 34 • 10 years ago

The thai keyboard will not be included unless the environment variable GAIA_KEYBOARD_LAYOUTS has 'th' included in the values. The Makefile in top level gaia directory has this environment variable with the selection that shows up as default. Many of the keyboard layouts that are in apps/keyboard/js/layouts/ are not in this list in the Makefile, so I did not add it there. I don't know what the criteria is to have it included there. Perhaps a more complete localization for that language?

	Francesco Lodolo [:flod]
	Comment 35 • 10 years ago

(In reply to Greg Green from comment #34)
> Perhaps a more complete localization for that language?

Not really. Most of localizations are complete but don't ship as default keyboard. As far as I know we need bugs like 1029951 fixed before extending that list.

	Yeojin Chung [:YeojinC]
	Comment 36 • 10 years ago

The Thai keyboard is verified fixed on Flame Master.

Result: After pushing Thai keyboard, it was successfully installed and fully functional. 

Device: Flame 3.0
Build ID: 20150130093240
Gaia: 5ce984fe5ac8d600bd65068ee1eee27b99c03e5b
Gecko: d7e156a7a0a6
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0