Closed
Bug 844959
Opened 12 years ago
Closed 12 years ago
Tabs are hidden after a tap on privacy tab button and a rotation
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: ju.vermet, Assigned: lucasr)
References
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
tabs.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130221 Firefox/22.0
Build ID: 20130221072044
Steps to reproduce:
Prerequisites :
* Normal mode (No privacy)
* No privacy tab opened
* Portrait mode
1. Tap tabs counter
2. Tap privacy tab button
3. Rotate device (to landscape)
4. TwoWayView height is null
5. Tap normal tab button
Actual results:
TwoWayView height is still null despite I have tabs opened
Expected results:
TwoWayView shows tabs opened with normal mode
|
Reporter | |
Updated•12 years ago
|
Summary: Tabs are hidden after a tap on privacy and a rotation → Tabs are hidden after a tap on privacy tab button and a rotation
|
||
Comment 1•12 years ago
|
||
I'm unable to reproduce your #4; on rotation I see the tabs positioned horizontally. Are you missing a step?
Blocks: 817735
|
Assignee | |
Comment 2•12 years ago
|
||
I know what's going on here. Working on it.
Assignee: nobody → lucasr.at.mozilla
|
||
Comment 3•12 years ago
|
||
I am able to reproduce this on:
-build: Firefox for Android 22.0a1 (2013-02-25)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.2
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #725609 -
Flags: review?(mark.finkle)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 725609 [details] [diff] [review]
Set an explicit height for horizontal tabs tray
Works OK on phones and tablets?
Attachment #725609 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 725609 [details] [diff] [review]
> Set an explicit height for horizontal tabs tray
>
> Works OK on phones and tablets?
Yep, tested on all form factors.
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e83371a150ef
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•