Closed
Bug 84508
Opened 23 years ago
Closed 22 years ago
Tinderbox should compile with -O on Linux to produce -Wuninitialized warnings.
Categories
(Webtools Graveyard :: Tinderbox, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla-bugs, Assigned: leaf)
References
Details
Attachments
(1 file)
When I compile Mozilla (by rebuilding a "daily" source RPM) on RedHat Linux 7.1,
I see several hundred "`xxx' might be used uninitialized in this function"
warnings. However, I can see none (or almot none) of them in Tinderbox.
Some of these warnings are probably harmless, but others indicate nasty bugs
that can take quite a while to figure out if the warnings are supressed (see for
example bug 81851 - it took me a few hours to track it and having the warning on
helped a lot).
The reason that Tinderbox is not showing these warnings despite -Wall is that
gcc will only produce it when ran with -O.
Comment 1•23 years ago
|
||
I think speedracer is an optimized -O build, can you check those logs?
Reporter | ||
Comment 2•23 years ago
|
||
Well, speedracer is a Dep build, so even if it is -O, there is no
straightforward way to get the full warnings list out of it.
Comment 3•23 years ago
|
||
speedracer isn't fast enough to do opt builds. I'll try to find a machine for this.
Reporter | ||
Comment 4•23 years ago
|
||
Comment 5•23 years ago
|
||
shrike is doing opt/clobber/warn builds, marking fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•23 years ago
|
||
Are you sure? I do not see and "uninitialized" warning in shrike warn logs and
the build logs do not show --enable-optimized...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•23 years ago
|
||
yes you are right, sorry I thought shrike was opt.
let me ask leaf about doing this.
Comment 8•23 years ago
|
||
over to leaf, can we get shrike to be an opt clobber build?
Assignee: mcafee → leaf
Status: REOPENED → NEW
Reporter | ||
Comment 9•23 years ago
|
||
"brad" is currently produces these warnings, so as far as I understand the only
thing left to do is to make sure these warnings are collected in a separate log
file, with blame counts, etc (for some reason such warning logs disappeared from
the Tinderbox).
Updated•23 years ago
|
Severity: major → minor
Priority: -- → P3
Reporter | ||
Comment 10•23 years ago
|
||
"brad" is now producing these warnings.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•23 years ago
|
||
For some reason somebody reconfigured brad a few hours ago and now it no longer
does optimized builds!
I used to run a script that would check with Tbox every few hours and would
notify me if any new "may be used uninitialized" warnings appeared which allowed
me to get people to fix those quickly. It would be unfortunate not to have this
anymore.
Severity: minor → normal
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•23 years ago
|
||
The Brad tbox was being fiddled with to track down the orangness (bug 122548 is
probably the reason for this) - thats why it was yellow. Not sure if the opt
removal was deliberate or not.
Brad?
Comment 13•23 years ago
|
||
oops.. when I restarted it last night I had my HOME set to the wrong thing so
it didn't pick up the right .mozconfig. I've restarted the build with the
right HOME so it should be back to --disable-debug --enable-optimize, thus
satisfying part of this request.
Reporter | ||
Comment 14•23 years ago
|
||
brad seems back to normal now. Thanks!
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•23 years ago
|
||
brad disappeared from the TBox over the last 4 hours, so now the -Wuninitialized
warnings are gone once again...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•23 years ago
|
||
Brad was having cvs problems, so it was taken off the page. You can still see it
by adding &noignore=1 to the url, but that won't help you since its not actually
building.
Comment 17•23 years ago
|
||
the build is working again. No need to panic for every little build failure.
Comment 18•23 years ago
|
||
oops, forgot to mark resolved
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 19•23 years ago
|
||
brad configuration seem to be changed once again. Currently it does not do an
optimized build and does not produce any -Wuninitialized warnings.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 20•23 years ago
|
||
for crying out loud. Read the *'s on the tree. I'm moving it around and
things are in flux. I really don't need a ticket every time somthing changes a
little. Sorry for sounding peeved, but I'm starting to think you need to be
doing your own build, or a /whole/ lot more patient.
Reporter | ||
Comment 21•23 years ago
|
||
Brad, I did read the *s and once things get back to normal I'd be as happy to
close this bug. But what's wrong with having it open as another indication of
the fact that things are in flux? ;-)
Comment 22•23 years ago
|
||
That kind of reminder just adds work and doesn't help. If I'd been done and
things were back to normal and the build wasn't doing an opt build, maybe it
have been worth reporting. Even then, a quick note might have been better then
reopening this bug. Its not like turning them off was intentional.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 23•23 years ago
|
||
For some reason now TBox stopped showing any warning pages at all (even though
brad does pruduce them and they are available in the full log). Not sure, if
this is accidental or intentional, but in any case approaching 1.0 seems like a
good time to pay more attention to warnings, not less.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 24•23 years ago
|
||
reenabled
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 25•22 years ago
|
||
Brad warnings output is great and enables me to let people know quickly when
they check in new "may be used uninitialized" warnings...
Marking Verified.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 26•22 years ago
|
||
Brad, is "brad" off tbox1 for good? Just asking to figure out whether it is time
for me to update my scripts that keep track of "uninitialized" warning to use
tbox2 instead (once bug 186970 that makes the logs unaccessible is resolved)?
Comment 27•22 years ago
|
||
Let's reopen this bug to deal with the Brad tbox issue.
Talking about this in a closed bug log is just gonna get lost.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 28•22 years ago
|
||
The seattle area got hit with a /big/ windstorm, knocking out power for 36
hours. The ups can only weather (pardon the pun) about 1 hour. The box is
back online now and the tinderbox build is restarted.
Reporter | ||
Comment 29•22 years ago
|
||
Yeah, brad is back on TBox 1.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 30•21 years ago
|
||
brad disappeared from TBox again ... :-(
Reporter | ||
Comment 31•20 years ago
|
||
It seems that brad have disappeared from TBox a few days ago. Is it coming back?
Is there a reason why the number of warnings in builds done by "comet" is not
tracked?
Comment 32•20 years ago
|
||
long closed bug, see dup bug #231998
Updated•10 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•