Changes: 1. Font and layout updates Refer to spec sheet 'Contacts Add' attached to bug: https://bugzilla.mozilla.org/show_bug.cgi?id=839220

See attached image for list of changes

Pavel, Przemek made further revisions to the screen. Please follow the after screens of this attachment. thx!

Hey Eric, I just found a little issue ... as you seen on the image, we have few actions on one line ... input, input clear button [x], and label(mobile, home, work, etc.) ... it's hard to clear the input because I open the label each time ... what do you think?

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3) > Created attachment 725847 [details] > case > > Hey Eric, > I just found a little issue ... as you seen on the image, we have few > actions on one line ... input, input clear button [x], and label(mobile, > home, work, etc.) ... it's hard to clear the input because I open the label > each time ... what do you think? Pavel, is this because the input clear button [x] is too close to the label drop down?

Yep

(In reply to Pavel Ivanov [:ivanovpavel] from comment #5) > Yep What if we move the hit area of the label drop down a few pixels to the right? That way there's less space to accidentally press either action button. Maybe somewhere close to where the text starts in the drop down? Przemek, what do you think?

I think we can move the label to the left and this will prevent future problems with RTL direction.

(In reply to Pavel Ivanov [:ivanovpavel] from comment #7) > I think we can move the label to the left and this will prevent future > problems with RTL direction. Hey Pavel, we'll see what Przemek thinks since he designed the screens.

(In reply to Eric Pang [:epang] from comment #8) > (In reply to Pavel Ivanov [:ivanovpavel] from comment #7) > > I think we can move the label to the left and this will prevent future > > problems with RTL direction. > > Hey Pavel, we'll see what Przemek thinks since he designed the screens. Pavel, I've talked with Przemek about this, we think it makes sense to add more padding to the right of the delete input button to prevent the accidental pressing of the label drop down.

Part of LG's request for font updates.

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

(In reply to Eric Pang [:epang] from comment #9) > (In reply to Eric Pang [:epang] from comment #8) > > (In reply to Pavel Ivanov [:ivanovpavel] from comment #7) > > > I think we can move the label to the left and this will prevent future > > > problems with RTL direction. > > > > Hey Pavel, we'll see what Przemek thinks since he designed the screens. > > Pavel, I've talked with Przemek about this, we think it makes sense to add > more padding to the right of the delete input button to prevent the > accidental pressing of the label drop down. Hi Pavel, let me know if you have questions about this.

can you create mockup for me? Thanks in advance

Hi Pavel, Thinking about this more, I think it works to have the drop downs on the left away from the delete buttons. I've created a mock up of how this will look. Przemek, what do you think? If you think this is good Pavel is good to implement. Thanks!

Comment on attachment 731990 [details] Contact Form Mock Up Hi Eric, yes this can work. I'm guessing that we can't make "Personal" fit in that drop down button?

(In reply to Przemek Abratowski [:przemek] UX from comment #16) > Comment on attachment 731990 [details] > Contact Form Mock Up > > Hi Eric, yes this can work. I'm guessing that we can't make "Personal" fit > in that drop down button? Przemek, doesn't look like we'll be able to with the space and font size atm. Pavel, this is good to implement now. Let me know if you have any questions. Thanks!

(In reply to Pavel Ivanov [:ivanovpavel] from comment #18) > Created attachment 732876 [details] > After patch Looks good, thanks!

Comment on attachment 732877 [details] patch for Gaia repo Comment available on github for the review. https://github.com/mozilla-b2g/gaia/pull/8972

I thing that this one is ready now :) thanks Sam

Hi guys, we're changing a huge amount of building blocks here, centering text in buttons (we're not using anywhere else), and basically making huge changes to commonly agreed components. I have my concerns about what you're proposing here will involve huge changes in the rest of the UI. May i ask who has agreed to implement these changes you're proposing? Thanks

Hey guys just to clarify: attachment 720827 [details] https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=720827 from comment 2 is incorrect. The redesign proposed here is incorrect, (the buttons should not have centred text) as Sergi has stated. Therefore attachment 731990 [details] https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=731990 from Comment 15 is also incorrect. However attachment 732876 [details] https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=732876 from Comment 20 looks correct (with the text justified Left). I assume this was produced post realising how the value selectors worked as discussed with Przemek. If we are following attachment 732876 [details] we're good to go. (If not let me know ASAP). cheers

(In reply to steve from comment #24) > Hey guys just to clarify: > > attachment 720827 [details] > https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=720827 > from comment 2 is incorrect. The redesign proposed here is incorrect, (the > buttons should not have centred text) as Sergi has stated. > > Therefore > > attachment 731990 [details] > https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=731990 > from Comment 15 is also incorrect. > > However > > attachment 732876 [details] > https://bug845085.bugzilla.mozilla.org/attachment.cgi?id=732876 > from Comment 20 looks correct (with the text justified Left). I assume this > was produced post realising how the value selectors worked as discussed with > Przemek. If we are following attachment 732876 [details] we're good to go. > (If not let me know ASAP). > > cheers Steve, yes attachment 732876 [details] is the way it's is being implemented. Pavel, one issue I noticed... Can you left align the text in the drop downs with the header and other text? thanks!

(In reply to Pavel Ivanov [:ivanovpavel] from comment #26) > Created attachment 737883 [details] > After patch Hey Pavel, sorry the type doesn't look right in the drop downs. The drop downs and buttons should have the same type > 17px, Medium, 1.7rem. Can you check that they are both correct? Thanks!

Comment on attachment 738981 [details] After patch This looks good now, thanks for making the changes Pavel!

Comment on attachment 732877 [details] patch for Gaia repo Alberto, has the original patch broke contacts could you please review this patch to check everything is fixed with this one?

Comment on attachment 732877 [details] patch for Gaia repo I've not checked if it visually fits the specified design, but the bug with the horizontal scroll is not there anymore :)

Comment on attachment 732877 [details] patch for Gaia repo Pavel, there is a small issue here, the 'No contacts' panel is broken. You need to be more specific on the .small selector to fix it. So few changes. Ping me back when it's done so i can r+ and merge it to master.

ping :)

Hi guys! We are currently reverting bug 845097 which this bug depends on so please DO NOT MERGE the pull request to avoid having to revert it too ;-) Thanks!

German: Can you ping me when you are ready!

Ping! :-p BTW, please, do not hesitate to contact me via Skype: gtorodelvalle, since I have issues with accessing the IRC channel :-(

Is this done/ready to be closed?

Hi Stephany, I've closing this bug since we ran into issues will implemented and had to revert. But looking at the device it looks like many changes have made it through other bugs :)