Closed
Bug 845368
Opened 12 years ago
Closed 12 years ago
Generic vertex attribs should have a size of 4
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
The failing test is state/gl-get-calls.html in the 1.0.2 WebGL Conf Test Suite:
failed: context.getVertexAttrib(ii, context.VERTEX_ATTRIB_ARRAY_SIZE) should be 4. Was 0.
This is really vague in the GLES2 spec, with the only decent reference being in the default state table.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 718459 [details] [diff] [review]
patch
Review of attachment 718459 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/canvas/src/WebGLContext.cpp
@@ +563,5 @@
> // Make sure that we clear this out, otherwise
> // we'll end up displaying random memory
> gl->fBindFramebuffer(LOCAL_GL_FRAMEBUFFER, 0);
>
> + gl->fScissor(0, 0, mWidth, mHeight);
Oops, this is for fixing a different bug.
Attachment #718459 -
Flags: review?(bjacob) → review-
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #718459 -
Attachment is obsolete: true
Attachment #718562 -
Flags: review?(bjacob)
|
||
Updated•12 years ago
|
Attachment #718562 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•