Closed
Bug 845387
Opened 12 years ago
Closed 12 years ago
private-browsing isPrivate should take a content script instance
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
For example:
PageMod({
...
onAttach: function(mod) {
require('private-browsing').isPrivate(mod); // should be true when the window is private
// require('private-browsing').isPrivate(mod.tab) is already true, but should have a test
}
})
Priority: -- → P1
Priority: P1 → P2
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → evold
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #724680 -
Flags: review?(poirot.alex)
Assignee | ||
Updated•12 years ago
|
Blocks: sdk-pwpb-fx21
Updated•12 years ago
|
Attachment #724680 -
Flags: review?(poirot.alex) → review+
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/e14076eff7bee97d70b29e2939eb2231d03c5597
Bug 845387: private-browsing isPrivate should take a content script instance
https://github.com/mozilla/addon-sdk/commit/86d1660710cd4436c8e076a4142ddfc923af4140
Merge pull request #853 from erikvold/845387
Bug 845387: private-browsing isPrivate should take a content script instance
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•