Closed
Bug 845441
Opened 12 years ago
Closed 12 years ago
Put DEBUG_CC out of its misery
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: khuey, Assigned: khuey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
The leak finding abilities have been subsumed by cycle collector dumps, and the other stuff isn't terribly useful anyways.
Attachment #718513 -
Flags: review?(continuation)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 718513 [details] [diff] [review]
Patch
Review of attachment 718513 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with these things fixed
::: xpcom/base/nsCycleCollector.cpp
@@ +200,1 @@
>
Please remove this trailing whitespace while you are here.
@@ -758,5 @@
> // is 32,544 bytes, which leaves 8 bytes for mNext.
> nsPurpleBufferEntry mEntries[1365];
>
> - Block() : mNext(nullptr) {
> -#ifndef DEBUG_CC
This is #ifndef, not #ifdef, so don't delete the assert.
Attachment #718513 -
Flags: review?(continuation) → review+
|
|
||
Comment 2•12 years ago
|
||
peterv and smaug said they were okay with removing this over IRC. Nobody is really using it any more.
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•