Closed Bug 845499 Opened 12 years ago Closed 12 years ago

Nightly UI on Ouya looks wrong

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(3 files)

Attached image Screenshot (deleted) —
See attached screenshot. That's the latest nightly running on the Ouya.
This appears to be happening because in resources/layout-large-v11/browser_toolbar_menu.xml.in, the Gecko.ImageButton with +id/menu has an android:visibility="gone" and so it gets laid out at 0,0 with size 0x0. Then the menu_items LinearLayout which is supposed to be to the left of that gets positioned wrongly, and the RelativeLayout that contains the awesome_bar is also positioned wrongly. Making the menu visibility "visible" fixes the problem but of course also makes the menu button appear on the toolbar.
Attached patch Fix sIsSmallTablet cache (deleted) — Splinter Review
Something I found while poking around.
Assignee: nobody → bugmail.mozilla
Attachment #723451 - Flags: review?(sriram)
Comment on attachment 723451 [details] [diff] [review] Fix sIsSmallTablet cache :D :D
Attachment #723451 - Flags: review?(sriram) → review+
Comment on attachment 723452 [details] [diff] [review] Fix for ouya (or tablets with hardware menu button) Looks good to me.
Attachment #723452 - Flags: review?(sriram) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: