Closed Bug 845574 Opened 12 years ago Closed 11 years ago

mozmill --info home-page invalid

Categories

(Testing Graveyard :: Mozmill, defect)

Product:
Testing Graveyard
Component:
Mozmill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nebelhom, Assigned: nebelhom)

References

Details

(Whiteboard: [mozmill-1.5.22+])

Attachments

(1 file)

1st patch attempt
(deleted), patch
davehunt
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 Build ID: 20130218103317 Steps to reproduce: on command line: mozmill --info Actual results: ... Home-page: http://github.com/mozautomation/mozmill ... Expected results: Correct Homepage given
Thanks Johannes, The correct home page URL is https://github.com/mozilla/mozmill could you provide a patch? The offending line is here https://github.com/mozilla/mozmill/blob/hotfix-1.5/mozmill/setup.py#L52 I highly doubt we'll push a new 1.5.x release just for this, but it would be good to know that if we do push another version it will have the correct URL.
Whiteboard: [mozmill-1.5.22?]
I need to ask, because this is the first time I have encountered this. Do you want me to submit a patch for the hotfix-1.5 branch (the one you linked to) or the master? I apologise if this is a daft question (or even makes sense), but I don't know what the protocol is here. Thanks
I believe the issue does not exist in master. Please confirm, and provide patches only where the fix is needed.
Attached patch 1st patch attempt (deleted) — — Splinter Review
@davehunt: You were right as usual. the issue was only in the hotfix1.5 branch. I didn't realise that they were so significantly different. I attached the first attempt. As usual I hope that I used git correctly. By now, I should put a sig that says something like "Use with caution" ;)
Attachment #719069 - Flags: review?(dave.hunt)
Whiteboard: [mozmill-1.5.22?] → [mozmill-1.5.22+]
Comment on attachment 719069 [details] [diff] [review] 1st patch attempt Review of attachment 719069 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Landed as: https://github.com/mozilla/mozmill/commit/5901bac8114ad40db42b8593c413ab27df8dacb9
Attachment #719069 - Flags: review?(dave.hunt) → review+
This bug is fixed. The problem does not appear on master. Closing. Thank you Johannes!
Assignee: nobody → mozilla_dev
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
I thought this was fixed months ago...
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: