Closed
Bug 845750
Opened 12 years ago
Closed 12 years ago
GCLI strings jsbBraceStyleDesc2 and jsbBraceStyleManual2 need descriptive comments
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file)
(deleted),
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
jsbBraceStyleManual2=Select the coding style of braces: collapse - put braces on the same line as control statements; expand - put braces on own line (Allman / ANSI style); end-expand - put end braces on own line; expand-strict - put braces on own line even if it will break your code. 1) My understanding is that collapse, end-expand, etc. should not be translated, since they're parameter values. Am I right? In this case a localization comment should be added to explain it. 2) "even if it will break your code". Breaking the code means that the code is no more functional or something else?
Assignee | ||
Comment 1•12 years ago
|
||
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #0) > jsbBraceStyleManual2=Select the coding style of braces: collapse - put > braces on the same line as control statements; expand - put braces on own > line (Allman / ANSI style); end-expand - put end braces on own line; > expand-strict - put braces on own line even if it will break your code. > > 1) My understanding is that collapse, end-expand, etc. should not be > translated, since they're parameter values. Am I right? In this case a > localization comment should be added to explain it. > Correct, I have added a comment to clarify this. > 2) "even if it will break your code". Breaking the code means that the code > is no more functional or something else? It may no longer be functional. I have added a comment to clarify this.
Attachment #718898 -
Flags: review?(fayearthur)
Assignee | ||
Updated•12 years ago
|
Summary: GCLI jsb command should strings jsbBraceStyleDesc2 and jsbBraceStyleManual2 need descriptive comments → GCLI strings jsbBraceStyleDesc2 and jsbBraceStyleManual2 need descriptive comments
Whiteboard: [has-patch]
Updated•12 years ago
|
Attachment #718898 -
Flags: review?(fayearthur) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [has-patch] → [land-in-fx-team]
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8ecc6063cbd7
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Updated•12 years ago
|
Status: NEW → ASSIGNED
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ecc6063cbd7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•