right now, all perf tests include a loop. It would be perfect to have this handled by performance helper instead, but this involves dealing with generator stuff. Also, it would be nice that the run number could be specified from an env variable.

Pointer to Github pull-request

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 Giving this to :rik :)

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 r+ with one var scope to change.

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 Sorry, removing my r+ as I noticed one method name is very confusing.

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 OK, new commit up with you review comments addressed.

landed here: https://github.com/mozilla-b2g/gaia/commit/4582a3d40740981b1c642550a6482c5568df24d5

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Harder to uplift other performance testing code. Testing completed: Datazilla build works since that commit Risk to taking this patch (and alternatives if risky): none, not part of the build. String or UUID changes made by this patch:

Rik, I think that you could even cherry-pick/push this yourself if you want, with "a=npotb" in the first line of the commit log.

Comment on attachment 722654 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8530 a=nptob indeed, please go ahead with uplift.

I tried to uplift but it seems dependent on bug 837673 which itself depends on bug 838527 and bug 837139.

Note: these bugs have an approval so we should be fine.

I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 4582a3d40740981b1c642550a6482c5568df24d5 <RESOLVE MERGE CONFLICTS> git commit

v1-train: d0d5ef158d868c7e22df1bf2d778739e1cbe596e