Closed
Bug 846539
Opened 12 years ago
Closed 12 years ago
IonMonkey: Remove jsop_call_inline()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: sstangl, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
jsop_call_inline() largely duplicates the behavior of inlineScriptedCall(), for the purpose of being more amenable to inclusion in inlineScriptedCalls(). By making small changes around the callsite of inlineScriptedCalls(), we can standardize on invariants and reuse the existing code.
Normalizing invariants eliminates a lot of messiness for Bug 837312.
Passes jit-tests and runs Octane.
Attachment #719713 -
Flags: review?(kvijayan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 719713 [details] [diff] [review]
patch
Review of attachment 719713 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #719713 -
Flags: review?(kvijayan) → review+
|
Reporter | |
Comment 2•12 years ago
|
||
|
|
Reporter | |
Comment 3•12 years ago
|
||
Backed out for exciting warnings-as-errors that only reproduce on clang builds:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f61a73af62dd
|
|
Reporter | |
Comment 4•12 years ago
|
||
"return NULL" => "return false":
https://hg.mozilla.org/integration/mozilla-inbound/rev/36e5e8f66118
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•