Closed
Bug 846696
Opened 12 years ago
Closed 12 years ago
GCLI helpers.js should be shared rather than copied
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: jwalker, Assigned: jwalker)
Details
Attachments
(1 file)
|
(deleted),
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
There are several copies of the same file. We should use this technique instead.
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Developing_tests#JavaScript_test-only_modules
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 753745 [details] [diff] [review]
v1
Review of attachment 753745 [details] [diff] [review]:
-----------------------------------------------------------------
Splendidly done.
Attachment #753745 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=dea12c804f30
https://hg.mozilla.org/integration/fx-team/rev/776fafd014db
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•