Firefox v1.0.0, build identifier： 20130222145933 +++ This bug was initially created as a clone of Bug #410338 +++ DEFECT DESCRIPTION: Format of AAC/Amr_nb do not support REPRODUCING PROCEDURES: Only support AAC+/OGG/MP3, but AAC/Amr_nb do not support. EXPECTED BEHAVIOUR: Per VPM's request,need support AAC+/OGG/MP3/AAC/Amr_nb. ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: REPRODUCING RATE: For FT PR, Please list reference mobile's behavior: ++++++++++ end of initial bug #410338 description ++++++++++ CONTACT INFO (Name,Phone number): DEFECT DESCRIPTION: REPRODUCING PROCEDURES: EXPECTED BEHAVIOUR: ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: REPRODUCING RATE: For FT PR, Please list reference mobile's behavior:

Reference bug: bug 783212.

Test results: AAC+/eAAC/MP3/OGG are supported. 3GP/ AAC/amr_nb/amr_wb/ eAAC +/mmf/midi/WAV/WMA are not supported.

partner will provide more information

For amr nb case you can refer : Bug 847809

Joe, seems Bug847809 has patch already, can we have it on V1.0.1 branch? And any update for AAC format?

Chris, it looks like we may have AAC issues on B2G.

It's a bit hard for me to understand this bug report. What's the problem exactly? Do we not support an audio format that is required? Does bug 847809 not fix it? How was it tested? The browser won't support AMR with the patch in bug 847809. Only privileged apps do. Does the device have decoders for the requested format? Can I have an STR?

needinfo for comment 10

The PR means, the attachment music files are not recognized by music player. But, they should be supported.One is AMR-NB, another one is ACC.

Bug 847809 landed AMR support. Has this been tested since that landed? I can't test until tomorrow but can report back then. A similar patch would need to be done for AAC.

(In reply to Chris Double (:doublec) from comment #13) > Bug 847809 landed AMR support. Has this been tested since that landed? I > can't test until tomorrow but can report back then. A similar patch would > need to be done for AAC. I can confirm that neither file plays in the music app. Looking at the Gaia music app source it doesn't seem to handle AMR or AAC files so it's not even getting to the Gecko playback code. The list of MP4 types in the music app is: 'M4A ' 'M4B ' 'mp42' The type in the AAC file is '3gp6'. There is no code to handle the AMR file. It falls back to using the Gecko canPlayType implementation but this tries to use the media sniffer to determine the file type. Our media sniffer does not, afaik, handle AMR files - it needs the mime type. The Music player should probably look for '#!AMR' and parse the file like it does the other formats.

If I add '3gp6' to the MP4 type list in the music app then the AAC file plays.

Per comment #14, the change is in the Gaia Music app. Leo+, as this was required in order to even basic inter-device testing of audio MMS.

Thanks Chris, the part you mentioned how music app handles *.aac is correct. And for *.amr files, DeviceStorage properties will filter out the *.amr files so I don't think music app has a chance to get *.amr and parse them into the MediaDB, we have to add *.amr to the deviceStorage properties for music before we fix the parser in music app.

(In reply to Chris Double (:doublec) from comment #15) > If I add '3gp6' to the MP4 type list in the music app then the AAC file > plays. I think this result is valid on m-c not on b2g18 or b2g18_v1.0.1. Because Gecko used nsMediaSniffer and nsExternalHelperAppService to filter known media type. nsMediaSniffer can't recognize this AAC file (not .aac but .m4a) because there is no "mp4" signature. nsExternalHelperAppService has a mapping between m4a and audio/mp4 but jus on m-c only not b2g branch. This is also related to the Bug 859711.

Hi Doug, 1. According Bug 847809 already added support to *.amr file for privileged app, we need add it to filter type of amr too. 2. I found a patch removed *.m4v from music filter because it is not a music but don't it be put on video filter? Hi Chris, 1. As I knew that we don't support *.aac (https://bugzilla.mozilla.org/show_bug.cgi?id=807361#c27) So I removed aac from filter type. Thanks.

Comment on attachment 745048 [details] [diff] [review] Patch DeviceStorage.Propoerty v1 To type the correct reviewer mail and please refer to comment 19 for the purpose of this patch. Thanks.

Comment on attachment 745048 [details] [diff] [review] Patch DeviceStorage.Propoerty v1 Review of attachment 745048 [details] [diff] [review]: ----------------------------------------------------------------- If this is okay with cdouble..

Add reviewer and approval reason.

The amr support is caused by bug 847809 for MMS spec so wait for that bug as leo+ too then asking for checkin.

Add a patch for checking in on b2g18 branch.

Created two test cases to check that if a user tries and listening to each of the files they play properly and are listed in the music app. https://moztrap.mozilla.org/manage/cases/?filter-id=9413 https://moztrap.mozilla.org/manage/cases/?filter-id=9414