Closed
Bug 847205
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Add optimized (Double BITOP Int32) stubs
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: djvj, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Mandreel hits this a lot. For now handling BITAND and BITOR is sufficient.
|
||
Comment 1•12 years ago
|
||
Are you testing with off thread compilation on Mandreel? Because of the different compilation thresholds, we should be Ion compiling everything that is hot on Mandreel when compiling off thread, but not in other builds.
|
Reporter | |
Comment 2•12 years ago
|
||
You're right, with off thread compilation on Mandreel these don't show up.
However, box2d and navier stokes do hit them pretty heavily in that case.
|
|
Reporter | |
Comment 3•12 years ago
|
||
Just adds handling for bitxor, bitand, and bitor ops for (Double, Int32) or (Int32, Double).
Cuts out another 150k or so fallback hits between box2d and navier stokes.
Attachment #720540 -
Flags: review?(bhackett1024)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 720540 [details] [diff] [review]
Patch.
Review of attachment 720540 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/BaselineIC.cpp
@@ +2293,5 @@
> return false;
> stub->addNewStub(doubleStub);
> return true;
> }
> + default: // Fall-through
rm comment
Attachment #720540 -
Flags: review?(bhackett1024) → review+
|
|
Reporter | |
Comment 5•12 years ago
|
||
Fixed and pushed: https://hg.mozilla.org/projects/ionmonkey/rev/a1af5476f427
Waiting for tbpl to close.
|
|
Reporter | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•