Closed
Bug 847303
Opened 12 years ago
Closed 11 years ago
WCF__setFilterTextBoxEvents timer could be GC'd before firing
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: past, Unassigned)
References
Details
(Whiteboard: [fixed by bug 878186])
After reading the following posts, I found an instance of nsITimer that may be susceptible to being GC'd before firing:
http://www.joshmatthews.net/blog/2011/03/nsitimer-anti-pattern/
https://groups.google.com/d/topic/mozilla.dev.platform/IDjMJNczoKg/discussion
Here is the code in question:
http://dxr.mozilla.org/mozilla-central/browser/devtools/webconsole/webconsole.js#l507
It may be that 250ms is short enough to never trigger this bug in practice, but I think it would be prudent to just store a reference to the timer and clear it afterwards.
Comment 1•12 years ago
|
||
Good catch. This will be fixed no later than the web console output rewrite, which will rework how filtering works.
Blocks: console-output
Comment 2•12 years ago
|
||
Pasting a relevant link so we don't forget about it:
https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Timer.jsm
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 878186]
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•