Closed
Bug 847354
Opened 12 years ago
Closed 12 years ago
Avoid the xbl bindings for inputs/textareas on b2g
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
(Whiteboard: [FFOS_perf])
Attachments
(1 file)
|
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Those bindings targets desktop builds since they are used for key shortcuts. Let's not slow down app startup time and consume memory for them by not loading them.
Attachment #720634 -
Flags: review?(fabrice)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 720634 [details] [diff] [review]
Patch
Review of attachment 720634 [details] [diff] [review]:
-----------------------------------------------------------------
We want to keep these bindings in desktop builds imho. So #ifdef MOZ_WIDGET_GONK please.
Attachment #720634 -
Flags: review?(fabrice) → review+
Why didn't this land?
|
|
||
Comment 3•12 years ago
|
||
No good reason... we just forgot about it, and it's not tracked anywhere. I'll push that later today.
|
|
||
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
E/GeckoConsole( 696): [JavaScript Warning: "Unexpected end of file while searching for ',' or '{'. Ruleset ignored due to bad selector." {file: "chrome://browser/content/content.css" line: 293}]
|
|
||
Comment 7•12 years ago
|
||
(In reply to Kan-Ru Chen [:kanru] from comment #6)
> E/GeckoConsole( 696): [JavaScript Warning: "Unexpected end of file while
> searching for ',' or '{'. Ruleset ignored due to bad selector." {file:
> "chrome://browser/content/content.css" line: 293}]
Yeah, not sure why the file is not pre-processed properly...
You need to log in
before you can comment on or make changes to this bug.
Description
•