Closed
Bug 847527
Opened 12 years ago
Closed 12 years ago
A typo in metro/base/tests/Makefile.in
Categories
(Firefox for Metro Graveyard :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: raymondlee, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
There is a typo in a makefile which causes an error when building metro.
http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/tests/Makefile.in#34
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #720821 -
Flags: review?(mbrubeck)
|
|
Reporter | |
Comment 2•12 years ago
|
||
(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 720821 [details] [diff] [review]
> v1
Building metro is fine after applying this patch
|
|
Reporter | |
Updated•12 years ago
|
OS: All → Mac OS X
|
||
Updated•12 years ago
|
Blocks: metrov1triage
|
||
Comment 3•12 years ago
|
||
Comment on attachment 720821 [details] [diff] [review]
v1
Review of attachment 720821 [details] [diff] [review]:
-----------------------------------------------------------------
I tested this on Windows too just to make sure it doesn't break anything.
Attachment #720821 -
Flags: review?(mbrubeck) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
Attachment #720821 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
No longer blocks: metrov1triage
You need to log in
before you can comment on or make changes to this bug.
Description
•