Closed Bug 847597 Opened 12 years ago Closed 12 years ago

Paris binding for NotifyAudioAvailableEvent

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(3 files)

No description provided.
Depends on: 856338
Attached patch WIP (deleted) — Splinter Review
Need to get bug 856338 fixed first.
Attached patch patch (deleted) — Splinter Review
Not super nice, but hopefully we can get rid of this event once Audio API works well enough. https://tbpl.mozilla.org/?tree=Try&rev=79e5a32df4b4
Assignee: nobody → bugs
Attachment #741040 - Flags: review?(peterv)
Comment on attachment 741040 [details] [diff] [review] patch Review of attachment 741040 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/events/src/nsDOMNotifyAudioAvailableEvent.cpp @@ +143,5 @@ > + } > + > + nsAutoArrayPtr<float> buffer; > + if (!aFrameBuffer.IsNull()) { > + buffer = new float[aFrameBufferLength]; Hmm, don't we want this to be a fallible allocation? Seems like this could be controlled from script? ::: content/events/src/nsDOMNotifyAudioAvailableEvent.h @@ +39,5 @@ > float aTime); > > ~nsDOMNotifyAudioAvailableEvent(); > > + virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope) I suppose I should have commented about that in all the previous conversions :-/: MOZ_OVERRIDE. ::: dom/webidl/NotifyAudioAvailableEvent.webidl @@ +6,5 @@ > + > +interface NotifyAudioAvailableEvent : Event > +{ > + [Throws] > + readonly attribute any frameBuffer; This really should return Float32Array.
Attachment #741040 - Flags: review?(peterv) → review+
(In reply to Peter Van der Beken [:peterv] from comment #3) > > + [Throws] > > + readonly attribute any frameBuffer; > > This really should return Float32Array. But our current infrastructure for TypedArrays doesn't make it easy to cache the JS.
Ah, I was told the getter becomes JSObject*
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: