Closed
Bug 847705
Opened 12 years ago
Closed 10 years ago
Use ETags for API endpoints
Categories
(Marketplace Graveyard :: API, enhancement, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cvan, Unassigned)
Details
(Whiteboard: p=3)
ETags are kind of awesome. We should consider using them for our API endpoints. Would be nice to use with Fireplace.
Comment 1•12 years ago
|
||
See also: bug 845967.
Updated•12 years ago
|
Severity: normal → enhancement
Priority: -- → P4
Updated•12 years ago
|
Whiteboard: [fireplace] → [fireplace] p=3
Comment 2•12 years ago
|
||
This bug isn't possible due to user-specific data in the API's output.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment 4•12 years ago
|
||
None of the fireplace endpoints would find any benefit from this. And plus, we don't (and won't) cache full API responses across sessions.
Whiteboard: [fireplace] p=3 → p=3
Comment 5•12 years ago
|
||
I think this could become potentially very valuable as we add more APIs that update resources. If the ETag headers differ we know the resource has changed since loading it.
Comment 6•12 years ago
|
||
Agreed we still need it, removed fireplace blocker.
No longer blocks: 859511
Comment 7•11 years ago
|
||
Thanks to bug 946845 we'll have ETags in some specific circumstances (at the time I'm writing this comment, with the latest iteration, it's only when there is a 'cache' parameter in the query string, if it's a GET request and the status is 200).
However, this bug shouldn't be closed, because we'll want ETags more specific than the ones django provides, so that we're able to a) answer If-None-Match faster inside API code b) use ETags to avoid conflicts when doing PUT/PATCH c) have them in every situation.
Reporter | ||
Comment 8•11 years ago
|
||
Actually correction:
We are always setting ETags regardless, by setting django's `USE_ETAGS`:
https://github.com/mozilla/zamboni/blob/master/mkt/settings.py#L325-L326
Comment 9•10 years ago
|
||
Based on last comment.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•