Closed
Bug 847716
Opened 12 years ago
Closed 12 years ago
bindAttribLocation for /_?webgl_.*/ should generate INVALID_OPERATION
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
This wasn't very clear in the spec, but has since been rectified.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #721003 -
Flags: review?(bjacob)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 721003 [details] [diff] [review]
patch
Review of attachment 721003 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/canvas/src/WebGLContextValidate.cpp
@@ +347,5 @@
> + {
> + ErrorInvalidOperation("%s: string contains a reserved GLSL prefix", info);
> + return false;
> + }
> +
nsString API may be bad, but it does have a way to match substrings without producing an actual new string, right? See Find(),
http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsStringAPI.h#267
Attachment #721003 -
Flags: review?(bjacob) → review-
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 721003 [details] [diff] [review]
patch
Apparently nsString API is badder than I knew, doesn't allow Find on nsAString. a sad r+.
Attachment #721003 -
Flags: review- → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Comment 6•12 years ago
|
||
However, we do have StringBeginsWith...
You need to log in
before you can comment on or make changes to this bug.
Description
•